Add more typing information to manifold package

[tobiasdiez]

In extension of #29775, more typing information is added to the manifold package (and its dependencies).

Depends on #29775

CC: @tscrim @nthiery @mjungmath @egourgoulhon @fchapoton

Component: manifolds

Author: Tobias Diez

Branch/Commit: c403910

Reviewer: Matthias Koeppe, Tobias Diez, Michael Jung, Eric Gourgoulhon

Issue created by migration from https://trac.sagemath.org/ticket/31006

[sagetrac-git]

Changed commit from 8cfb932 to 874f853

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

874f853

Remove symplectic stuff

[mkoeppe]

comment:3

from future import annotations is not available in Python 3.6, which we still support, so I am adding #30551 (Drop Python 3.6 support) as a dependency

[fchapoton]

comment:4

same in #30989

[tobiasdiez]

Dependencies: #30551

[tobiasdiez]

comment:5

Good to know, (but isn't #30053 already breaking 3.6 support?)

[mkoeppe]

comment:6

Replying to @tobiasdiez:

isn't #30053 already breaking 3.6 support?

That was temporary, just for one beta during the 9.2 cycle. Python 3.6 support was restored in #30576, #30740, #30758.

[fchapoton]

comment:7

red branch

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

d74f6c9

Merge branch 'develop' of git://github.com/sagemath/sage into public/manifold/typing_more

[sagetrac-git]

Changed commit from 874f853 to d74f6c9

[tobiasdiez]

comment:9

Merged develop branch.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

5364cd6

Add a bit more typing

[sagetrac-git]

Changed commit from d74f6c9 to 5364cd6

[mkoeppe]

comment:12

Now that we have dropped support for Python 3.6 (#30551), there is no obstacle to using from future import annotations any more.

[mkoeppe]

Changed dependencies from #30551 to none

[fchapoton]

comment:13

red branch => needs work

[mkoeppe]

comment:48

Rebased onto narrowed #29775

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

a3905b5	src/sage/tensor/modules/free_module_tensor.py: Conditionalize an import with 'if TYPE_CHECKING:', add 'from `__future__` import annotations'
b2a68dc	src/sage/manifolds/differentiable/manifold.py: Conditionalize imports with 'if TYPE_CHECKING:'
2061a50	src/sage/manifolds/differentiable/degenerate.py: Conditionalize an import with 'if TYPE_CHECKING:'
056a69d	src/sage/manifolds/differentiable/degenerate_submanifold.py: Conditionalize an import with 'if TYPE_CHECKING:'
f813f3c	src/sage/manifolds/differentiable/tensorfield.py: Don't string-quote types
196f705	Add a bit more typing
afd661a	src/sage/tensor/modules: Add missing 'from `__future__` import annotations'
37da606	src/sage/tensor/modules/free_module_tensor.py: Fixup

[sagetrac-git]

Changed commit from b28af09 to 37da606

[mkoeppe]

comment:50

Rebased onto updated #29775

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

eb83a23	src/sage/manifolds/differentiable/manifold.py: Conditionalize an import with 'if TYPE_CHECKING:'
6d382df	src/sage/manifolds/differentiable/tensorfield_paral.py: Conditionalize imports with 'if TYPE_CHECKING:'
5a92de8	src/sage/manifolds/differentiable/vectorfield_module.py: Conditionalize an import with 'if TYPE_CHECKING:'
71138ff	src/sage/manifolds/manifold.py: Conditionalize imports with 'if TYPE_CHECKING:'
2527267	src/sage/tensor/modules/format_utilities.py: Conditionalize an import with 'if TYPE_CHECKING:'
79a7003	src/sage/tensor/modules/free_module_tensor.py: Merge two 'if TYPE_CHECKING:' blocks

[sagetrac-git]

Changed commit from 37da606 to 79a7003

[tobiasdiez]

comment:52

As all remarks seem to be addressed, Matthias is fine with my changes and I'm with his, I'll set it back to positively reviewed.

[tobiasdiez]

Changed reviewer from Matthias Koeppe, ... to Matthias Koeppe, Tobias Diez

[egourgoulhon]

comment:53

Merge failure with Sage 9.6.beta6

[sagetrac-git]

Changed commit from 79a7003 to c403910

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

51ee92b	Add a bit of typing to manifold code
974ec0a	src/sage/tensor/modules/free_module_tensor.py: Conditionalize an import with 'if TYPE_CHECKING:', add 'from `__future__` import annotations'
9905ade	src/sage/manifolds/differentiable/manifold.py: Conditionalize imports with 'if TYPE_CHECKING:'
ba751f1	src/sage/manifolds/differentiable/degenerate.py: Conditionalize an import with 'if TYPE_CHECKING:'
3beb020	src/sage/manifolds/differentiable/degenerate_submanifold.py: Conditionalize an import with 'if TYPE_CHECKING:'
7c18c7f	src/sage/manifolds/differentiable/tensorfield.py: Don't string-quote types
c403910	Merge remote-tracking branch 'origin/public/manifolds/typing' into public/manifold/typing_more

[tobiasdiez]

comment:55

Merged latest version of #29775

[egourgoulhon]

comment:56

As in #29775, the coverage issue reported by the patchbot is a spurious one, due to the use of @overload.

Michael, do you agree with the positive review?

[egourgoulhon]

Changed reviewer from Matthias Koeppe, Tobias Diez to Matthias Koeppe, Tobias Diez, Michael Jung, Eric Gourgoulhon

[tobiasdiez]

comment:57

Thanks!

[mjungmath]

comment:58

Replying to @egourgoulhon:

Michael, do you agree with the positive review?

Yes. I still find some style changes unnecessary, e.g.

-    def set_embedding(self, phi, inverse=None, var=None,
-                      t_inverse=None):
+    def set_embedding(
+        self, phi: ContinuousMap, inverse=None, var=None, t_inverse=None
+    ):

leaving a glimpse of inconsistency behind. If that could be changed: I am happy. But I can also live with this. I would just appreciated it if we can stick to previously established styling rules in the future. Otherwise the code becomes more a patchwork rug than it already is.

[vbraun]

Changed branch from public/manifold/typing_more to c403910