-
-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MR51: Allow Matplotlib to use system qhull >= 7.2.0 #31148
Comments
This comment has been minimized.
This comment has been minimized.
Reviewer: Dima Pasechnik |
comment:2
lgtm |
comment:3
Full name in Author field please. |
Changed author from zlscherr to Zachary Scherr |
This comment has been minimized.
This comment has been minimized.
comment:5
Thanks! |
comment:6
The cffi upgrade that is on the ticket should be mentioned in the ticket description |
comment:7
Oops, that's my fault since I'm still learning about contributing. That was leftover from the last ticket I submitted as I had merged it into my local develop branch. Is there an easy way to separate those or should I just submit a new ticket? Sorry about that. |
Dependencies: #31128 |
comment:8
As the branch is on top of the one of #31128, it's OK to just add that ticket as a dependency. I have just done that. (Best practice, however, would be to have independent branches for independent tickets.) |
comment:9
Thanks. Also, what is best practice for package dependencies? Matplotlib depends on numpy which depends on pkgconfig, which I use in this ticket. Does that mean I should explicitly add pkgconfig to Matplotlib's dependency file? |
comment:10
It would be clearer to add it explicitly; |
comment:11
I just opened #31165 to deal with system-wide qhull. We should also update our qhull. |
Changed branch from u/galois/mrs/51/matplotlib_qhull_fix to |
zlscherr (@zlscherr) opened a merge request at https://gitlab.com/sagemath/sage/-/merge_requests/51:
produces
if the system has qhull 8.0.0 installed.
The text was updated successfully, but these errors were encountered: