Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MACOSX_VERSION is not always defined during the build process #31186

Closed
jhpalmieri opened this issue Jan 5, 2021 · 8 comments
Closed

MACOSX_VERSION is not always defined during the build process #31186

jhpalmieri opened this issue Jan 5, 2021 · 8 comments

Comments

@jhpalmieri
Copy link
Member

It should be, rather than having each package define it if it wants it. It is used here:

% git grep MACOSX_VERSION build/pkgs/
build/pkgs/curl/spkg-install.in:    if [ $MACOSX_VERSION -ge 16 ]; then
build/pkgs/curl/spkg-install.in:        echo "OS X 10.$[$MACOSX_VERSION-4] Building with clang and --with-darwinssl."
build/pkgs/pari/spkg-install.in:MACOSX_VERSION=`uname -r | awk -F. '{print $1}'`
build/pkgs/pari/spkg-install.in:if [ $MACOSX_VERSION -ge 14 ]; then
build/pkgs/psutil/spkg-install.in:if [ "$UNAME" = "Darwin" ] && [ $MACOSX_VERSION -ge 16 ]; then
build/pkgs/psutil/spkg-install.in:    echo "OS X 10.$[$MACOSX_VERSION-4] Building with clang."
build/pkgs/python3/spkg-build.in:    if [ $MACOSX_VERSION -ge 16 ]; then
build/pkgs/python3/spkg-build.in:        echo "OS X 10.$[$MACOSX_VERSION-4] Building with clang."
build/pkgs/r/spkg-install.in:    if [ $MACOSX_VERSION -ge 14 ]; then
build/pkgs/r/spkg-install.in:        echo "OS X 10.$[$MACOSX_VERSION-4] Configuring R without aqua support."
build/pkgs/r/spkg-install.in:    if [ $MACOSX_VERSION -ge 16 ]; then
build/pkgs/r/spkg-install.in:        echo "OS X 10.$[$MACOSX_VERSION-4] Building with clang."

It is defined in src/bin/sage-env (and also in build/pkgs/pari/spkg-install.in).

Component: build

Author: John Palmieri

Branch/Commit: 8df3d27

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/31186

@jhpalmieri jhpalmieri added this to the sage-9.3 milestone Jan 5, 2021
@jhpalmieri
Copy link
Member Author

Branch: u/jhpalmieri/MACOSX_VERSION

@jhpalmieri
Copy link
Member Author

Commit: 8df3d27

@jhpalmieri
Copy link
Member Author

New commits:

8df3d27trac 31186: on OS X, always define MACOSX_VERSION in sage-env

@jhpalmieri
Copy link
Member Author

Author: John Palmieri

@jhpalmieri

This comment has been minimized.

@mkoeppe
Copy link
Contributor

mkoeppe commented Jan 6, 2021

Reviewer: Matthias Koeppe

@jhpalmieri
Copy link
Member Author

comment:5

Great, thanks!

@vbraun
Copy link
Member

vbraun commented Jan 17, 2021

Changed branch from u/jhpalmieri/MACOSX_VERSION to 8df3d27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants