Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build/pkgs: Add some missing install-requires metadata, add some documentation to the developer's guide #31321

Closed
mkoeppe opened this issue Feb 1, 2021 · 16 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 1, 2021

Dmitry Marakasov (repology.org) points out that some metadata are missing in our build/pkgs/.
repology/repology-updater#1118 (comment)

We fix this so that the SageMath distribution can be listed as a repository on repology.org

CC: @slel @dimpase @kiwifb @seblabbe @jhpalmieri @tobiasdiez

Component: build

Author: Matthias Koeppe

Branch/Commit: f829357

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/31321

@mkoeppe mkoeppe added this to the sage-9.3 milestone Feb 1, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 1, 2021

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 1, 2021

Commit: 5a92c51

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 1, 2021

New commits:

18466f0build/pkgs/wheel/install-requires.txt: New
8ec310esrc/doc/en/developer/packaging.rst: Explain install-requires.txt (from https://wiki.sagemath.org/ReleaseTours/sage-9.3)
5a92c51build/pkgs/texttable/install-requires.txt: New

@mkoeppe mkoeppe changed the title build/pkgs: Add some missing metadata build/pkgs: Add some missing metadata, add some documentation to the developer's guide Feb 1, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 1, 2021

comment:3

#29152 adds the missing upstream_url fields for rw, cliquer, meataxe.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 1, 2021

Author: Matthias Koeppe

@mkoeppe mkoeppe changed the title build/pkgs: Add some missing metadata, add some documentation to the developer's guide build/pkgs: Add some missing install-requires metadata, add some documentation to the developer's guide Feb 1, 2021
@slel
Copy link
Member

slel commented Feb 3, 2021

comment:6

Should there be a space between >= and the version number?

In one case there is no space, in the other there is one:

texttable >=1.6.3
wheel >= 0.36.2

Wondering whether this matters here.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 3, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

52add22build/pkgs/wheel/install-requires.txt: No space after >=

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 3, 2021

Changed commit from 5a92c51 to 52add22

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 3, 2021

comment:8

Thanks for catching this, I want to standardize on the format without the space.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 5, 2021

comment:9

Needs review

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 7, 2021

Changed commit from 52add22 to f829357

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 7, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

f829357Merge tag '9.3.beta7' into t/31321/build_pkgs__add_some_missing_metadata

@dimpase
Copy link
Member

dimpase commented Feb 8, 2021

comment:11

lgtm

@dimpase
Copy link
Member

dimpase commented Feb 8, 2021

Reviewer: Dima Pasechnik

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 8, 2021

comment:12

Thanks!

@vbraun
Copy link
Member

vbraun commented Mar 9, 2021

Changed branch from u/mkoeppe/build_pkgs__add_some_missing_metadata to f829357

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants