sage.env.sage_include_directories: Remove hard dependency on numpy

[mkoeppe]

(extracted from and needed for #29865)

sage_include_directories returns the basic list of include directories for compiling extensions, not including directories obtained through pkgconfig etc. This basic list includes directories supplied by numpy. This is fine for the monolithic Sage library because numpy is a standard package; but in the course of modularization, we will have various distributions that do not need the dependency on numpy.
We use try/expect around the import and call to numpy.

CC: @kiwifb @tobiasdiez

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: 4550eb6

Reviewer: François Bissey

Issue created by migration from https://trac.sagemath.org/ticket/31333

[mkoeppe]

Branch: u/mkoeppe/sage_env_sage_include_directories__remove_hard_dependency_on_numpy

[mkoeppe]

Author: Matthias Koeppe

[mkoeppe]

Commit: 19776a3

[mkoeppe]

New commits:

19776a3

sage.env.sage_include_directories: Do not fail if numpy cannot be imported

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

e16ba2d

src/sage/doctest/control.py: Do not fail if sage.libs.arb cannot be imported

[sagetrac-git]

Changed commit from 19776a3 to e16ba2d

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

[sagetrac-git]

Changed commit from e16ba2d to 19776a3

[tobiasdiez]

comment:5

I think there should still be a log message if numpy couldn't be found, since otherwise errors further down the compile chain might be hard to track down.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

4550eb6

sage.env.sage_include_directories: Do not fail if numpy cannot be imported

[sagetrac-git]

Changed commit from 19776a3 to 4550eb6

[kiwifb]

comment:9

The branch looks fine. Can the description be a bit more verbose on what this change will achieve? Obviously it makes the thing touched more resilient but for what purpose.

[kiwifb]

Reviewer: François Bissey

[kiwifb]

comment:11

LGTM.

[mkoeppe]

comment:12

Thanks!

[tobiasdiez]

comment:13

+    try:
+        import numpy
+        dirs.append(numpy.get_include())
+    except ModuleNotFoundError:
+        pass

Should this not better print an error message in case numpy is not found?

[mkoeppe]

comment:14

No, the whole point of this ticket is that it's not an error.

[vbraun]

Changed branch from u/mkoeppe/sage_env_sage_include_directories__remove_hard_dependency_on_numpy to 4550eb6