-
-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixup src/VERSION.txt added in #30912 #31357
Comments
This comment has been minimized.
This comment has been minimized.
Commit: |
Last 10 new commits:
|
Author: Matthias Koeppe |
comment:3
So we're going to have the version recorded in another non-auto-generated file? |
comment:4
It is auto-generated by |
comment:5
This file needs to be there at the time that one would prepare an |
comment:6
Should the symlink In the I'm basically really confused about the different version files. |
comment:7
Thanks for catching these mistakes... I'll fix it up |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Reviewer: John Palmieri |
comment:9
Thanks for the fixes. I think this is okay. |
comment:10
Thank you! |
Changed branch from u/mkoeppe/fixup_src_version_txt_added_in__30912 to |
The mistake made in #30912 broke the direct use of
src/setup.py
. (Did not affect normal build.)Depends on #30912
CC: @jhpalmieri @tobiasdiez @isuruf
Component: build
Author: Matthias Koeppe
Branch/Commit:
043d3ab
Reviewer: John Palmieri
Issue created by migration from https://trac.sagemath.org/ticket/31357
The text was updated successfully, but these errors were encountered: