Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use deprecated numpy type aliases #31364

Closed
antonio-rojas opened this issue Feb 8, 2021 · 20 comments
Closed

Don't use deprecated numpy type aliases #31364

antonio-rojas opened this issue Feb 8, 2021 · 20 comments
Labels
c: packages: standard p: major / 3 t: enhancement
Milestone
sage-9.3

Comments

@antonio-rojas
Copy link
Contributor

The type aliases numpy.int, numpy.float and numpy.complex are deprecated in numpy 1.20, and the deprecation warnings cause lots of test failures.

We port these to the respective builtin types.

Depends on #31191

CC: @mkoeppe @kiwifb @slel

Component: packages: standard

Author: Antonio Rojas

Branch/Commit: 0f2f58a

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/31364
@antonio-rojas antonio-rojas added this to the sage-9.3 milestone Feb 8, 2021
@antonio-rojas
Copy link
Contributor Author

Branch: u/arojas/don_t_use_deprecated_numpy_type_aliases

@antonio-rojas

This comment has been minimized.

Sign in to view
@antonio-rojas
Copy link
Contributor Author

Author: Antonio Rojas

@antonio-rojas
Copy link
Contributor Author

comment:2

Needs testing on older pythons

New commits:

6544b79Don't use deprecated numpy type aliases

@antonio-rojas
Copy link
Contributor Author

Commit: 6544b79

@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 9, 2021

comment:3

Looks like several import numpy as np can be removed from doctests

@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 9, 2021

comment:4

Testing on Python 3.6 is currently blocked by #31191

@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 18, 2021

Dependencies: #31191

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 20, 2021

Changed commit from 6544b79 to dfdef60

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 20, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

dfdef60Remove obsolete numpy imports

@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 20, 2021

Reviewer: https://github.com/mkoeppe/sage/actions/runs/584627033

@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 20, 2021

Changed reviewer from https://github.com/mkoeppe/sage/actions/runs/584627033 to https://github.com/mkoeppe/sage/actions/runs/584631860

@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 21, 2021

Changed reviewer from https://github.com/mkoeppe/sage/actions/runs/584631860 to Matthias Koeppe

@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 21, 2021

comment:9

Looking OK also on ubuntu-bionic-standard (which uses system python 3.6) - https://github.com/mkoeppe/sage/runs/1942659778

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 7, 2021

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

cf7b513Merge branch 'develop' of git://git.sagemath.org/sage into t/31364/don_t_use_deprecated_numpy_type_aliases

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 7, 2021

Changed commit from dfdef60 to cf7b513

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 7, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

0f2f58aFix merge

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 7, 2021

Changed commit from cf7b513 to 0f2f58a

@antonio-rojas
Copy link
Contributor Author

comment:12

Rebased

@vbraun
Copy link
Member

vbraun commented Mar 9, 2021

Changed branch from u/arojas/don_t_use_deprecated_numpy_type_aliases to 0f2f58a

@vbraun vbraun closed this as completed in 70cbb47 Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: packages: standard p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.3
Development

No branches or pull requests
3 participants
@vbraun @mkoeppe @antonio-rojas