Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch giac so that libintl from /usr/local does not leak in on macOS #31562

Closed
mkoeppe opened this issue Mar 26, 2021 · 15 comments
Closed

Patch giac so that libintl from /usr/local does not leak in on macOS #31562

mkoeppe opened this issue Mar 26, 2021 · 15 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Mar 26, 2021

Crucial for building binary distributions on systems that have homebrew installed.

CC: @vbraun @kiwifb @dimpase @sagetrac-parisse @frederichan-IMJPRG

Component: packages: standard

Author: Matthias Koeppe

Branch/Commit: 89f61d2

Reviewer: François Bissey

Issue created by migration from https://trac.sagemath.org/ticket/31562

@mkoeppe mkoeppe added this to the sage-9.3 milestone Mar 26, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 26, 2021

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 26, 2021

comment:1

Attachment: giac-1.6.0.47p3.tar.bz2.gz

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 26, 2021

Commit: 1b0a9ee

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 26, 2021

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

1ef46d0build/pkgs/giac: Add another patch in patches/autotools
1b0a9eebuild/pkgs/giac: Update to 1.6.0.47p3

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 26, 2021

Author: Matthais Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 26, 2021

Changed author from Matthais Koeppe to Matthias Koeppe

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 26, 2021

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

89f61d2build/pkgs/giac: Update to 1.6.0.47p3

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 26, 2021

Changed commit from 1b0a9ee to 89f61d2

@kiwifb
Copy link
Member

kiwifb commented Mar 29, 2021

comment:7

Current upstream release (1.7.0-1) has

ALL_LINGUAS="es fr el pt it en zh de"
AM_GNU_GETTEXT
AM_GNU_GETTEXT_VERSION([0.14.5])
dnl for Slowlaris comment next line
dnl AC_CHECK_LIB(intl, main) 

Not sure if it meant to be "uncomment for solaris" but upstream has already commented it in the main body. I note, however that it is still checked over again for cygwin when gui is on.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 29, 2021

comment:8

Thanks! Yes, I have not attempted to make changes to the cygwin code.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 30, 2021

comment:9

Let's get this in please.

@kiwifb
Copy link
Member

kiwifb commented Mar 30, 2021

Reviewer: François Bissey

@kiwifb
Copy link
Member

kiwifb commented Mar 30, 2021

comment:10

Looks good as is. Ship it.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 30, 2021

comment:11

Thanks!

@vbraun
Copy link
Member

vbraun commented May 27, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants