Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing command to plantri #31590

Closed
slel opened this issue Apr 1, 2021 · 11 comments
Closed

Allow passing command to plantri #31590

slel opened this issue Apr 1, 2021 · 11 comments

Comments

@slel
Copy link
Member

slel commented Apr 1, 2021

Allow passing command to plantri, similar
to what graphs.nauty_geng allows for nauty.

As suggested in #31571.

CC: @fchapoton @dcoudert @slel

Component: graph theory

Author: David Coudert

Branch: 37a5b40

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/31590

@slel slel added this to the sage-9.4 milestone Apr 1, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.4, sage-9.5 Jul 19, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Dec 18, 2021
@dcoudert
Copy link
Contributor

dcoudert commented Jan 5, 2022

Branch: public/graphs/31590_plantri

@dcoudert
Copy link
Contributor

dcoudert commented Jan 5, 2022

Commit: 7537643

@dcoudert
Copy link
Contributor

dcoudert commented Jan 5, 2022

Author: David Coudert

@dcoudert
Copy link
Contributor

dcoudert commented Jan 5, 2022

comment:3

This is a first version of the method.

  • the name plantri_gen might not be best possible. Could be simply plantri ?
  • I use a try except statement but I'm not sure it's the best way. We have an error when the combination of parameters does not allow plantri to generate any graph. Should we instead return nothing ?
  • I have documented some parameters that are part of version 5.2 (release in 2021) but not of 4.5 (version released in 2011 that we use). I have opened Update plantri to 5.2 #33120 to update to plantri 5.2.

New commits:

7537643trac #31590: allow passing command to plantri

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 5, 2022

Changed commit from 7537643 to 37a5b40

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 5, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

37a5b40trac #31590: add missing optional statements

@dcoudert
Copy link
Contributor

dcoudert commented Jan 5, 2022

comment:5

Should be ok now.

@mkoeppe
Copy link
Contributor

mkoeppe commented Mar 7, 2022

Reviewer: Matthias Koeppe

@vbraun
Copy link
Member

vbraun commented Mar 9, 2022

Changed branch from public/graphs/31590_plantri to 37a5b40

@jhpalmieri
Copy link
Member

Changed commit from 37a5b40 to none

@jhpalmieri
Copy link
Member

comment:8

See #34245 for a followup: there is a bad doctest created by this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants