-
-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ManifoldSubset: Add methods subset_family, superset_family, open_superset_family; deprecate method list_of_subsets #31727
Comments
Commit: |
Last 10 new commits:
|
Dependencies: #31718 |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
|
This comment has been minimized.
This comment has been minimized.
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
This comment has been minimized.
This comment has been minimized.
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits: |
comment:13
Removed the last commit; the addition of |
comment:14
Ready for review. |
comment:16
LGTM. Thanks! |
Reviewer: Eric Gourgoulhon |
comment:18
Thanks for the review! |
Follow-up from #31718.
This ticket proposes to deprecate
list_of_subsets
(note - no other methods insage.manifolds
follow this naming scheme) in favor of a new methodsubset_family
, which prints in a more compact way, is hashable, and is sorted by name too.We also add
superset_family
(previously the set of supersets was not exposed by a method).We also add
open_superset_family
(to complementopen_superset
added in #31677).Depends on #31718
Depends on #31677
CC: @egourgoulhon @mjungmath @tscrim
Component: manifolds
Author: Matthias Koeppe
Branch/Commit:
2b47b1b
Reviewer: Eric Gourgoulhon
Issue created by migration from https://trac.sagemath.org/ticket/31727
The text was updated successfully, but these errors were encountered: