Bug in plotting 3d polyhedron with rays, add option polygon='rainbow'

[yuan-zhou]

Visually, there is no different between the two plots:

p = Polyhedron(rays=[(0, 0, 1)],lines=[(1, 0, 0), (0, 1, 0)])
p.plot()
q = Polyhedron(lines=[(1, 0, 0), (0, 1, 0)])
q.plot()

The bug seems to be caused by sage.geometry.polyhedron.Projection._init_solid_3d, which discards the rays. There might also be a bug in sage.geometry.polyhedron.Projection._init_lines_arrows, but I'm not sure how to plot the arrows in this example.

CC: @mkoeppe @fchapoton @dcoudert @slel @jplab

Component: geometry

Author: Yuan Zhou

Branch/Commit: fbd18ca

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/31802

[yuan-zhou]

Branch: u/yzh/bug_in_plotting_3d_polyhedron_with_rays

[sagetrac-git]

Commit: 331c351

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

331c351

Plot 3d polytope with rainbow colors

[sagetrac-git]

Changed commit from 331c351 to 1909108

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

1909108

revise Projection._init_lines_arrows, take care of rays/lines that are not on a facet, small edits to plotting arguments and docstrings

[yuan-zhou]

Author: Yuan Zhou

[sagetrac-git]

Changed commit from 1909108 to bf0b645

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

bf0b645

fix bug on the number of polygons

[sagetrac-git]

Changed commit from bf0b645 to d27c745

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

d27c745

improve implementation for Polyhedron 3d plot argument polygon=rainbow

[kliem]

comment:10

@mkoeppe, @yuan-zhou: Can you please add you polyhedral tickets to https://trac.sagemath.org/wiki/SagePolyhedralGeometry.

That makes it easier to see what is going on and we also use this for the release notes.

[mkoeppe]

comment:11

Setting a new milestone for this ticket based on a cursory review.

[mkoeppe]

comment:12

Stalled in needs_review or needs_info; likely won't make it into Sage 9.5.

[fchapoton]

comment:13

red branch => needs_work

[mkoeppe]

Changed branch from u/yzh/bug_in_plotting_3d_polyhedron_with_rays to u/mkoeppe/bug_in_plotting_3d_polyhedron_with_rays

[mkoeppe]

comment:15

Rebased on current beta

---

New commits:

82b4464	Plot 3d polytope with rainbow colors
583f546	revise Projection._init_lines_arrows, take care of rays/lines that are not on a facet, small edits to plotting arguments and docstrings
0840246	fix bug on the number of polygons
aa1f49a	improve implementation for Polyhedron 3d plot argument polygon=rainbow
445448f	src/sage/geometry/polyhedron/plot.py: Fix import, syntax warning on 'is with literal'

[mkoeppe]

Changed commit from d27c745 to 445448f

[mkoeppe]

comment:17

The new rainbow option should be documented.

The changes to point_opts, line_opts need to be motivated

[mkoeppe]

Reviewer: Matthias Koeppe

[yuan-zhou]

Changed branch from u/mkoeppe/bug_in_plotting_3d_polyhedron_with_rays to u/yzh/bug_in_plotting_3d_polyhedron_with_rays

[yuan-zhou]

New commits:

ec96adf

add examples and explanations on rainbow option, point_opts, line_opts

[yuan-zhou]

Changed commit from 445448f to ec96adf

[mkoeppe]

comment:21

patchbot indicates doctest failure

[sagetrac-git]

Changed commit from ec96adf to 6ab5646

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

6ab5646

decorate rainbow color 3d plot doctest with # optional - sage.plot

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

fe86804

fix typo in doctest for plot3d polyhedron

[sagetrac-git]

Changed commit from 6ab5646 to fe86804

[mkoeppe]

Changed branch from u/yzh/bug_in_plotting_3d_polyhedron_with_rays to u/mkoeppe/bug_in_plotting_3d_polyhedron_with_rays

[mkoeppe]

comment:26

This seems to work well.

---

New commits:

fbd18ca

src/sage/geometry/polyhedron/base6.py: Small docstring edits

[mkoeppe]

Changed commit from fe86804 to fbd18ca

[vbraun]

Changed branch from u/mkoeppe/bug_in_plotting_3d_polyhedron_with_rays to fbd18ca