-
-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ABC for convex sets #31919
Comments
Branch: u/mkoeppe/abc_for_convex_sets |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Commit: |
Author: Matthias Koeppe |
Dependencies: #31916 |
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
|
This comment has been minimized.
This comment has been minimized.
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:11
Missing doctest.
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:13
I guess it is back on needs review. |
comment:14
Can you please add doctests for |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:36
Replying to @kliem:
I have made a similar fix |
comment:37
Replying to @kliem:
Yes, this was a great improvement! |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:39
|
comment:41
Cherry-picking 1448835 from #31959 was a mistake, thanks for catching this. |
comment:42
Patchbot is green modulo the unrelated |
comment:43
We could replace the imports in
|
comment:44
Fine with me if you want to make this change |
comment:45
Actually I think after #31705 this won't matter |
comment:47
One tiny thing about Either way, LGTM. |
comment:48
Thank you! We can make refinements to |
This comment has been minimized.
This comment has been minimized.
Changed branch from u/mkoeppe/abc_for_convex_sets to |
We create a base class
ConvexSet_base
with abstract methods to define an API for convex sets (convex subsets of a finite dimensional topological R-vector space such asR^n
).We use it to test/unify the API of
Polyhedron
,ConvexRationalPolyhedralCone
,LatticePolytope
,RelativeInterior
(#31916)See also:
PolyhedronFace
: Make it a subclass ofConvexSet_closed
ConvexSet_base
: Add methodsan_element
,some_elements
ConvexSet.contains
: Handle symbolic argumentDepends on #31916
CC: @kliem @yuan-zhou @jplab @tscrim @novoselt @orlitzky
Component: geometry
Author: Matthias Koeppe
Branch/Commit:
686d0af
Reviewer: Jonathan Kliem
Issue created by migration from https://trac.sagemath.org/ticket/31919
The text was updated successfully, but these errors were encountered: