Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH Actions: Deploy sdists to PyPI #32062

Closed
mkoeppe opened this issue Jun 25, 2021 · 17 comments
Closed

GH Actions: Deploy sdists to PyPI #32062

mkoeppe opened this issue Jun 25, 2021 · 17 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Jun 25, 2021

We extend the sdist.yml workflow from #32403 so that it builds sdists for PyPI using make pypi-sdists (from #29039).
This is run on release tags.

When the secret SAGEMATH_PYPI_API_TOKEN exists and the sdists were successfully created, it then proceeds to publish the sdists to PyPI using https://github.com/pypa/gh-action-pypi-publish

At the moment, the secret SAGEMATH_PYPI_API_TOKEN is only available in the repository https://github.com/mkoeppe/sage; in response to a release tag pushed to it, the workflow has successfully built the 9.5.beta6 release sdists (+ this branch): https://github.com/mkoeppe/sage/runs/4200645206?check_suite_focus=true and deployed to PyPI (see, for example https://pypi.org/project/sagemath-standard/9.5b6/)

Later we can move the deployment to https://github.com/sagemath/sage, simply by providing a secret SAGEMATH_PYPI_API_TOKEN to it. (We may want to add a safety check to the workflow that avoids pushing a release that hasn't had a release candidate.)

Depends on #29039
Depends on #32403

CC: @dimpase @jhpalmieri @kiwifb @tobiasdiez

Component: distribution

Author: Matthias Koeppe

Branch: cd51972

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/32062

@mkoeppe mkoeppe added this to the sage-9.4 milestone Jun 25, 2021
@mkoeppe

This comment has been minimized.

@mkoeppe mkoeppe modified the milestones: sage-9.4, sage-9.5 Aug 22, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 28, 2021

Changed dependencies from #29039 to #29039, #32403

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 13, 2021

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 13, 2021

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 13, 2021

Last 10 new commits:

aeca1a0Makefile (pypi-sdists): Add sage_setup
cd3dce9pkgs/sage-conf_pypi/setup.py: Update directory of configured sage_conf.py
c695921pkgs/sage-conf/sage_conf.py.in (SAGE_SPKG_WHEELS): Update so it works if SAGE_VENV != SAGE_LOCAL
cebcda3Merge tag '9.5.beta4' into t/29039/pip_installable_package_sage_bootstrap
0026892Merge tag '9.5.beta5' into t/29039/pip_installable_package_sage_bootstrap
a16df32Merge #29039
1261494.github/workflows/sdist.yml (deploy_sdists_pypi): New
a21cb3cMakefile (pypi-sdists): Remove duplication of sage_setup
099b385.github/workflows/sdist.yml: Only attempt to upload if secrets.SAGEMATH_PYPI_API_TOKEN is present
899d8cb.github/workflows/sdist.yml: Fix up test whether token is present

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 13, 2021

Commit: 899d8cb

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 2, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

2a4a323Merge tag '9.5.beta7' into t/29039/pip_installable_package_sage_bootstrap
cd51972Merge #29039

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 2, 2021

Changed commit from 899d8cb to cd51972

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 2, 2021

comment:8

Let's get this in please

@dimpase
Copy link
Member

dimpase commented Dec 2, 2021

Reviewer: Dima Pasechnik

@dimpase
Copy link
Member

dimpase commented Dec 2, 2021

comment:9

OK, make pypi-sdists does seem to work.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 2, 2021

comment:10

Thanks!

@vbraun
Copy link
Member

vbraun commented Jan 1, 2022

Changed branch from u/mkoeppe/gh_actions__deploy_sdists_to_pypi to cd51972

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 11, 2022

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 11, 2022

Changed commit from cd51972 to none

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants