-
-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove sage.libs.readline #32073
Comments
This comment has been minimized.
This comment has been minimized.
comment:2
I think it is already defunct because in normal Sage terminal interaction, readline is not used, so whatever this interface is offering ( How about we just remove it immediately, without deprecation? |
comment:3
It's broken, no need for deprecation. |
New commits:
|
Author: Matthias Koeppe |
Commit: |
comment:6
This won't break again #14289, correct? I don't have an OSX machine to verify this. |
comment:7
This module is unused. Try a search for imports of it |
comment:8
Thanks. Then I will now apply fire and holy water to it. |
Reviewer: Travis Scrimshaw |
comment:9
Thanks! |
comment:10
Merge conflict |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:13
Documentation fails to build |
Changed branch from u/mkoeppe/deprecate_sage_libs_readline to u/tscrim/deprecate_readline-32073 |
comment:14
Removed the lib file from the reference manual. Doc builds for me. New commits:
|
Changed author from Matthias Koeppe to Matthias Koeppe, Travis Scrimshaw |
Changed reviewer from Travis Scrimshaw to Travis Scrimshaw, Matthias Koeppe |
Changed branch from u/tscrim/deprecate_readline-32073 to |
Unused, should remove.
It was added 8 years ago, in #14523, but the Python world has moved away from using readline: IPython is using different libraries for terminal interaction now.
CC: @dimpase @tscrim
Component: interfaces
Author: Matthias Koeppe, Travis Scrimshaw
Branch/Commit:
ed14848
Reviewer: Travis Scrimshaw, Matthias Koeppe
Issue created by migration from https://trac.sagemath.org/ticket/32073
The text was updated successfully, but these errors were encountered: