Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sage.libs.readline #32073

Closed
mkoeppe opened this issue Jun 28, 2021 · 22 comments
Closed

Remove sage.libs.readline #32073

mkoeppe opened this issue Jun 28, 2021 · 22 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Jun 28, 2021

Unused, should remove.

It was added 8 years ago, in #14523, but the Python world has moved away from using readline: IPython is using different libraries for terminal interaction now.

CC: @dimpase @tscrim

Component: interfaces

Author: Matthias Koeppe, Travis Scrimshaw

Branch/Commit: ed14848

Reviewer: Travis Scrimshaw, Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/32073

@mkoeppe mkoeppe added this to the sage-9.4 milestone Jun 28, 2021
@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 28, 2021

comment:2

I think it is already defunct because in normal Sage terminal interaction, readline is not used, so whatever this interface is offering (with interleaved_output()) can't work any more.

How about we just remove it immediately, without deprecation?

@dimpase
Copy link
Member

dimpase commented Jun 28, 2021

comment:3

It's broken, no need for deprecation.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 28, 2021

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 28, 2021

New commits:

c9e42ecsrc/sage/libs/readline.pyx: Unused, remove; remove dependency of sagelib on readline

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 28, 2021

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 28, 2021

Commit: c9e42ec

@mkoeppe mkoeppe changed the title Deprecate sage.libs.readline Remove sage.libs.readline Jun 28, 2021
@tscrim
Copy link
Collaborator

tscrim commented Jun 29, 2021

comment:6

This won't break again #14289, correct? I don't have an OSX machine to verify this.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 29, 2021

comment:7

This module is unused. Try a search for imports of it

@tscrim
Copy link
Collaborator

tscrim commented Jun 29, 2021

comment:8

Thanks. Then I will now apply fire and holy water to it.

@tscrim
Copy link
Collaborator

tscrim commented Jun 29, 2021

Reviewer: Travis Scrimshaw

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 29, 2021

comment:9

Thanks!

@vbraun
Copy link
Member

vbraun commented Jul 6, 2021

comment:10

Merge conflict

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 19, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

8feca2aMerge tag '9.4.beta5' into t/32073/deprecate_sage_libs_readline

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 19, 2021

Changed commit from c9e42ec to 8feca2a

@vbraun
Copy link
Member

vbraun commented Jul 20, 2021

comment:13

Documentation fails to build

@tscrim
Copy link
Collaborator

tscrim commented Jul 20, 2021

Changed commit from 8feca2a to ed14848

@tscrim
Copy link
Collaborator

tscrim commented Jul 20, 2021

@tscrim
Copy link
Collaborator

tscrim commented Jul 20, 2021

comment:14

Removed the lib file from the reference manual. Doc builds for me.


New commits:

ed14848Remove readline lib file from the documentation.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 20, 2021

Changed author from Matthias Koeppe to Matthias Koeppe, Travis Scrimshaw

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 20, 2021

Changed reviewer from Travis Scrimshaw to Travis Scrimshaw, Matthias Koeppe

@vbraun
Copy link
Member

vbraun commented Jul 24, 2021

Changed branch from u/tscrim/deprecate_readline-32073 to ed14848

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants