Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Lazy Power Series in species directory #32367

Closed
tejasvicsr1 opened this issue Aug 11, 2021 · 171 comments
Closed

Replace Lazy Power Series in species directory #32367

tejasvicsr1 opened this issue Aug 11, 2021 · 171 comments

Comments

@tejasvicsr1
Copy link
Contributor

In this ticket we finalize the implementation of lazy series, and replace the old lazy series framework.

Depends on #34423

CC: @mantepse @tscrim @pfili @zimmermann6 @sagetrac-tmonteil

Component: combinatorics

Keywords: LazyPowerSeries, FormalSeries, gsoc2021

Author: Tejasvi Chebrolu, Martin Rubey, Travis Scrimshaw

Branch/Commit: 4fc981b

Reviewer: Martin Rubey, Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/32367

@tejasvicsr1
Copy link
Contributor Author

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 11, 2021

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

651b372Revert "Merge branch 'u/gh-tejasvicsr1/special_functions_for_lazy_series' of git://trac.sagemath.org/sage into t/32324/lazy_taylor_series"
7c9a5ddfix invert
51357a0Small reworkings and fixes. Adding another composition test.
7501204Adding documentation to the user-facing class level documentation.
4723f6bRefactoring we discussed at the meeting today.
651c3edonly get coefficient if necessary
65e604dMerge branch 'u/mantepse/dense_lls-31897' of git://trac.sagemath.org/sage into t/32324/lazy_taylor_series
b332728fix and document series reversion
6a2391eMerge remote-tracking branch 'trac/u/mantepse/lazy_taylor_series' into t/32367/replace_lazy_power_series_in_species_directory_with_the_new_lazy_taylor_series
0d56b02Merged new Taylor series and deleted new_gs.py

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 11, 2021

Commit: 0d56b02

@tscrim
Copy link
Collaborator

tscrim commented Aug 12, 2021

Changed keywords from LazyPowerSeries, FormalSeries, GSoC21 to LazyPowerSeries, FormalSeries, gsoc2021

@tscrim
Copy link
Collaborator

tscrim commented Aug 12, 2021

Dependencies: #32324

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 13, 2021

Changed commit from 0d56b02 to 39993e3

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 13, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

39993e3Fixed the initialising issue.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 16, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

73b9964Fixed naming issue.
db20680Changed _gs_iterator to callables

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 16, 2021

Changed commit from 39993e3 to db20680

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 17, 2021

Changed commit from db20680 to 7d491f6

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 17, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

974fa4fChanged _list and _term methods.
6cfdf8dCreated restrict method in the series helper function.
eef15d8Changed the name of iterator to callable.
7d491f6Raised a not implemented error for all not corrected methods in the generating_series file.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 18, 2021

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

661c3d4backport two fixes from 32324
8a7dcd3fix oversight in shift
78b8fffLast trivial fix for clean pyflakes.
96771f0Merge branch 'u/tscrim/dense_lls-31897' of git://trac.sagemath.org/sage into t/32324/lazy_taylor_series
86925afinitial version of lazy symmetric functions
aa8a250initial and insanely stupid plethysm implementation
1a36f59add (currently failing) doctest for plethysm
03198a0fix bug in plethysm
eb3e88fmore doctests for composition and plethysm
a9084c6Merge branch 'u/mantepse/lazy_taylor_series' of git://trac.sagemath.org/sage into t/32367/replace_lazy_power_series_in_species_directory_with_the_new_lazy_taylor_series

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 18, 2021

Changed commit from 7d491f6 to a9084c6

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 18, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

4b76e93switch to power sum by default

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 18, 2021

Changed commit from a9084c6 to 4b76e93

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 24, 2021

Changed commit from 4b76e93 to 48e8e26

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 24, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

48e8e26Changed more methods.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 25, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

78a85aeSome more work in generating series.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 25, 2021

Changed commit from 48e8e26 to 78a85ae

@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Dec 18, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.6, sage-9.7 Apr 2, 2022
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 18, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

3d5b8cfLast little things from the patchbot.

@tscrim
Copy link
Collaborator

tscrim commented Sep 18, 2022

comment:123

Well, for now, let's bring this to a positive review and move onto the next ticket (assuming we get a green bot this time because I didn't do anything stupid). I will do stuff there starting from your changes.

I did a few little things from what I saw from the last patchbot report (the other failure seems unrelated). I made species library lazily imported to decrease the startup modules number.

@mkoeppe mkoeppe modified the milestones: sage-9.7, sage-9.8 Sep 19, 2022
@mantepse
Copy link
Collaborator

comment:125

The Returns in the doctring noticed by the patchbot is fixed in the follow-up ticket #34470.

The pyflakes warnings about imported but unused modules in species/library.py, are, as far as I know, unavoidable.

The ellipsis in the doctest in sfa.py is misinterpreted by the patchbot as a doctest continuation, but is correct, as far as I know.

I am therefore setting this to positive review.

@mantepse
Copy link
Collaborator

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 26, 2022

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. Last 10 new commits:

5d76825Merge branch 'u/chapoton/34494' of https://github.com/sagemath/sagetrac-mirror into u/tscrim/derivatives_lazy_series-34413
97df300Updating sf/sfa.py doctest due to #34494.
1388b8aMerge branch 'u/chapoton/34494' of https://github.com/sagemath/sagetrac-mirror into public/rings/lazy_series_revert-34383
7bfe5f7Merge branch 'public/rings/lazy_series_revert-34383' of https://github.com/sagemath/sagetrac-mirror into public/rings/lazy_series_revert-34383
2039990Updating doctest due to changes from #34494.
cdea820Merge branch 'public/rings/lazy_series_revert-34383' of https://github.com/sagemath/sagetrac-mirror into u/tscrim/derivatives_lazy_series-34413
b7f04edMerge branch 'develop' of trac.sagemath.org:sage into t/34413/derivatives_lazy_series-34413
2325826Merge branch 'u/mantepse/derivatives_lazy_series-34413' of trac.sagemath.org:sage into t/34422/implement_functorial_composition_of_lazy_symmetric_functiosn
ebcf5c3Merge branch 'u/mantepse/implement_functorial_composition_of_lazy_symmetric_functiosn' of trac.sagemath.org:sage into t/34423/implement_arithmetic_product_of_lazy_symmetric_functions
4172688Merge branch 'u/mantepse/implement_arithmetic_product_of_lazy_symmetric_functions' of trac.sagemath.org:sage into t/32367/replace_lazy_power_series-32367

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 26, 2022

Changed commit from 3d5b8cf to 4172688

@mantepse
Copy link
Collaborator

comment:129

trivial (autopmatic) merge, necessary to make the patchbots happy.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 30, 2022

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

67dff95Merge branch 'develop' of trac.sagemath.org:sage into t/32367/replace_lazy_power_series-32367
4fc981bfix for pyflakes and blocks

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 30, 2022

Changed commit from 4172688 to 4fc981b

@mantepse
Copy link
Collaborator

comment:131

trivial fixes to make patchbot happy.

@vbraun
Copy link
Member

vbraun commented Oct 11, 2022

Changed branch from u/mantepse/replace_lazy_power_series-32367 to 4fc981b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants