-
-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary uses of SR and symbolic functions in sage.algebras, sage.combinat #32411
Comments
Branch: public/ticket/32411 |
Commit: |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Author: Frédéric Chapoton |
comment:7
Thanks a lot, LGTM. |
Reviewer: Matthias Koeppe |
This comment has been minimized.
This comment has been minimized.
Changed branch from public/ticket/32411 to |
git grep -E '[.](symbolic|calculus|functions).*import'
reveals a number of calls to the symbolic calculus subsystem of Sage that can be avoided.Examples:
ArikiKoikeAlgebra._BasesCategory.ParentMethods.dimension
usessage.functions.other.factorial
although it only needsZZ.factorial
Likewise,
sage.categories.finite_dimensional_lie_algebras_with_basis
uses symbolicbinomial
but only needsZZ.binomial
ClassicalCrystals.ParentMethods.demazure_character
could be generalized to take a "variables" parameter so that users can obtain the result as an element of a polynomial ring instead of SR; or as a sympy expressionMany more examples like this in
sage.combinat
whenever counting formulas or similar are producedThis is part of Meta-ticket #29705 (modularization) - to remove unnecessary dependencies on the distribution
sagemath-symbolics
(#31695)CC: @tscrim
Component: refactoring
Author: Frédéric Chapoton
Branch/Commit:
ec09c4e
Reviewer: Matthias Koeppe
Issue created by migration from https://trac.sagemath.org/ticket/32411
The text was updated successfully, but these errors were encountered: