Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary uses of SR and symbolic functions in sage.algebras, sage.combinat #32411

Closed
mkoeppe opened this issue Aug 24, 2021 · 14 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 24, 2021

git grep -E '[.](symbolic|calculus|functions).*import' reveals a number of calls to the symbolic calculus subsystem of Sage that can be avoided.

Examples:

  • ArikiKoikeAlgebra._BasesCategory.ParentMethods.dimension uses sage.functions.other.factorial although it only needs ZZ.factorial

  • Likewise, sage.categories.finite_dimensional_lie_algebras_with_basis uses symbolic binomial but only needs ZZ.binomial

  • ClassicalCrystals.ParentMethods.demazure_character could be generalized to take a "variables" parameter so that users can obtain the result as an element of a polynomial ring instead of SR; or as a sympy expression

  • Many more examples like this in sage.combinat whenever counting formulas or similar are produced

This is part of Meta-ticket #29705 (modularization) - to remove unnecessary dependencies on the distribution sagemath-symbolics (#31695)

CC: @tscrim

Component: refactoring

Author: Frédéric Chapoton

Branch/Commit: ec09c4e

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/32411

@mkoeppe mkoeppe added this to the sage-9.5 milestone Aug 24, 2021
@fchapoton
Copy link
Contributor

Branch: public/ticket/32411

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 24, 2021

Commit: 4a95d8a

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 24, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

4a95d8achanging imports of binomial, factorial and floor in algebras and combinat

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 24, 2021

Changed commit from 4a95d8a to c1485e5

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 24, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

c1485e5remove one import of SR in combinat

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 24, 2021

Changed commit from c1485e5 to ad0b243

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 24, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

ad0b243fix typo

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 24, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

ec09c4efix in cluster

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 24, 2021

Changed commit from ad0b243 to ec09c4e

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 24, 2021

Author: Frédéric Chapoton

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 24, 2021

comment:7

Thanks a lot, LGTM.

@mkoeppe mkoeppe changed the title Remove unnecessary uses of SR and symbolic functions Remove unnecessary uses of SR and symbolic functions in sage.algebras, sage.combinat Aug 24, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 24, 2021

Reviewer: Matthias Koeppe

@mkoeppe

This comment has been minimized.

@vbraun
Copy link
Member

vbraun commented Sep 13, 2021

Changed branch from public/ticket/32411 to ec09c4e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants