Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary uses of SR and symbolic functions in sage.categories, sage.coding #32413

Closed
mkoeppe opened this issue Aug 24, 2021 · 10 comments
Closed

Remove unnecessary uses of SR and symbolic functions in sage.categories, sage.coding #32413

mkoeppe opened this issue Aug 24, 2021 · 10 comments
Labels
p: major / 3 t: enhancement t: refactoring
Milestone
sage-9.5

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 24, 2021

git grep -E '[.](symbolic|calculus|functions).*import' src/sage/coding reveals a number of calls to the symbolic calculus subsystem of Sage that can be avoided, similar to what is done in #32411

CC: @dimpase @fchapoton @tscrim

Component: refactoring

Author: Frédéric Chapoton

Branch/Commit: f96c696

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/32413
@mkoeppe mkoeppe added this to the sage-9.5 milestone Aug 24, 2021
@fchapoton
Copy link
Contributor

comment:1

some work done

New commits:

d0d7166some changes in imports in categories and coding, about binomial, floor etc

@fchapoton
Copy link
Contributor

Branch: public/ticket/32413

@fchapoton
Copy link
Contributor

Commit: d0d7166

@mkoeppe mkoeppe changed the title Remove unnecessary uses of SR and symbolic functions in sage.coding Remove unnecessary uses of SR and symbolic functions in sage.categories, sage.coding Aug 24, 2021
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 25, 2021

Changed commit from d0d7166 to f96c696

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 25, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

f96c696fix back import in grs_code

@fchapoton
Copy link
Contributor

comment:4

green bot now. Maybe there would be more things to remove

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 2, 2021

Author: Frédéric Chapoton

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 2, 2021

Reviewer: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 2, 2021

comment:6

LGTM. More can be done in follow-up tickets

@vbraun
Copy link
Member

vbraun commented Sep 13, 2021

Changed branch from public/ticket/32413 to f96c696

@vbraun vbraun closed this as completed in f91cda2 Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-9.5
Development

No branches or pull requests
3 participants
@vbraun @fchapoton @mkoeppe