Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing dependencies for Python packages revealed by #32492 #32493

Closed
mkoeppe opened this issue Sep 8, 2021 · 19 comments
Closed

Add missing dependencies for Python packages revealed by #32492 #32493

mkoeppe opened this issue Sep 8, 2021 · 19 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Sep 8, 2021

After reinstalling the Python packages using the instructions shown in #32492:

$ grep -B2 -r "Warning.*try.*no-deps" logs/pkgs
logs/pkgs/html5lib-1.0.1.log-pip._internal.exceptions.DistributionNotFound: No matching distribution found for webencodings
logs/pkgs/html5lib-1.0.1.log-Removed build tracker: '/private/var/folders/38/wnh4gf1552g_crsjnv2vmmww0000gp/T/pip-req-tracker-tafh_kg_'
logs/pkgs/html5lib-1.0.1.log:Warning: installing with "python3 -m pip install --verbose --no-index --find-links=/Users/mkoeppe/s/sage/sage-rebasing/worktree-rebase/venv-32492/var/lib/sage/wheels --disable-pip-version-check --isolated --no-cache-dir" failed. Retrying, adding "--no-deps --ignore-installed"
--
logs/pkgs/importlib_resources-5.1.4.log-pip._internal.exceptions.DistributionNotFound: No matching distribution found for zipp>=3.1.0; python_version < "3.10"
logs/pkgs/importlib_resources-5.1.4.log-Removed build tracker: '/private/var/folders/38/wnh4gf1552g_crsjnv2vmmww0000gp/T/pip-req-tracker-3gqjedfc'
logs/pkgs/importlib_resources-5.1.4.log:Warning: installing with "python3 -m pip install --verbose --no-index --find-links=/Users/mkoeppe/s/sage/sage-rebasing/worktree-rebase/venv-32492/var/lib/sage/wheels --disable-pip-version-check --isolated --no-cache-dir" failed. Retrying, adding "--no-deps --ignore-installed"
--
logs/pkgs/bleach-3.1.5.log-pip._internal.exceptions.DistributionNotFound: No matching distribution found for packaging
logs/pkgs/bleach-3.1.5.log-Removed build tracker: '/private/var/folders/38/wnh4gf1552g_crsjnv2vmmww0000gp/T/pip-req-tracker-v0hoaj95'
logs/pkgs/bleach-3.1.5.log:Warning: installing with "python3 -m pip install --verbose --no-index --find-links=/Users/mkoeppe/s/sage/sage-rebasing/worktree-rebase/venv-32492/var/lib/sage/wheels --disable-pip-version-check --isolated --no-cache-dir" failed. Retrying, adding "--no-deps --ignore-installed"
--
logs/pkgs/sagenb_export-3.3.log-pip._internal.exceptions.DistributionNotFound: No matching distribution found for notebook
logs/pkgs/sagenb_export-3.3.log-Removed build tracker: '/private/var/folders/38/wnh4gf1552g_crsjnv2vmmww0000gp/T/pip-req-tracker-gz3vbd0n'
logs/pkgs/sagenb_export-3.3.log:Warning: installing with "python3 -m pip install --verbose --no-index --find-links=/Users/mkoeppe/s/sage/sage-rebasing/worktree-rebase/venv-32492/var/lib/sage/wheels --disable-pip-version-check --isolated --no-cache-dir" failed. Retrying, adding "--no-deps --ignore-installed"

With the Jupyter upgrade in #31280 merged, there are a few more. We fix them all.

Depends on #31280

CC: @dimpase

Component: build

Author: Matthias Koeppe

Branch/Commit: 8a314c2

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/32493

@mkoeppe mkoeppe added this to the sage-9.5 milestone Sep 8, 2021
@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 9, 2021

Changed dependencies from #32492, #31280 to #31280

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 9, 2021

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 9, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

c929321build/pkgs/nbclient/dependencies: fixup
41224afbuild/pkgs/nbconvert/dependencies: Add missing dep
0fc01d3build/pkgs/zipp: Update to 3.5.0

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 9, 2021

Commit: 0fc01d3

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 9, 2021

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 9, 2021

comment:6

Tested now with #32492 using make -j50.

@mkoeppe

This comment has been minimized.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 9, 2021

Changed commit from 0fc01d3 to 8a314c2

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 9, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

8a314c2build/pkgs/bleach/dependencies: Add six

@dimpase
Copy link
Member

dimpase commented Sep 9, 2021

comment:9

how about

--- a/build/pkgs/ipykernel/dependencies
+++ b/build/pkgs/ipykernel/dependencies
@@ -1,4 +1,4 @@
-$(PYTHON) | ipython jupyter_client $(PYTHON_TOOLCHAIN) scandir
+$(PYTHON) | ipython jupyter_client $(PYTHON_TOOLCHAIN) scandir debugpy
 
 ----------
 All lines of this file are ignored except the first.

@dimpase
Copy link
Member

dimpase commented Sep 9, 2021

comment:10

Replying to @dimpase:

how about

--- a/build/pkgs/ipykernel/dependencies
+++ b/build/pkgs/ipykernel/dependencies
@@ -1,4 +1,4 @@
-$(PYTHON) | ipython jupyter_client $(PYTHON_TOOLCHAIN) scandir
+$(PYTHON) | ipython jupyter_client $(PYTHON_TOOLCHAIN) scandir debugpy
 
 ----------
 All lines of this file are ignored except the first.

oops, OK, that was already in.

@strogdon
Copy link

comment:11

Perhaps a separate issue but html docs for 9.5.beta1 will not build without debugpy.

cd /local/sage-git/sage && ./sage --docbuild --no-pdf-links reference/repl inventory --no-prune-empty-dirs
Warning: Could not import sage.repl.ipython_kernel.kernel No module named 'debugpy'
[repl     ] building [inventory]: targets for 36 source files that are out of date
[repl     ] updating environment: [new config] 36 added, 0 changed, 0 removed
[repl     ] WARNING: autodoc: failed to import module 'kernel' from module 'sage.repl.ipython_kernel'; the following exception was raised:
[repl     ] No module named 'debugpy'
[repl     ] The inventory files are in local/share/doc/sage/inventory/en/reference/repl.
Error building the documentation.

and

sage: from sage.repl.ipython_kernel import kernel
---------------------------------------------------------------------------
ModuleNotFoundError                       Traceback (most recent call last)
<ipython-input-1-ae6dbb0420a7> in <module>
----> 1 from sage.repl.ipython_kernel import kernel

/local/sage-git/sage/local/lib/python3.9/site-packages/sage/repl/ipython_kernel/kernel.py in <module>
     17 
     18 import sys
---> 19 from ipykernel.ipkernel import IPythonKernel
     20 from ipykernel.zmqshell import ZMQInteractiveShell
     21 from traitlets import Type

/local/sage-git/sage/local/lib/python3.9/site-packages/ipykernel/ipkernel.py in <module>
     18 from .zmqshell import ZMQInteractiveShell
     19 from .eventloops import _use_appnope
---> 20 from .debugger import Debugger
     21 from .compiler import XCachingCompiler
     22 

/local/sage-git/sage/local/lib/python3.9/site-packages/ipykernel/debugger.py in <module>
     15 
     16 # This import is required to have the next ones working...
---> 17 from debugpy.server import api
     18 from _pydevd_bundle import pydevd_frame_utils
     19 from _pydevd_bundle.pydevd_suspended_frames import SuspendedFramesManager, _FramesTracker

ModuleNotFoundError: No module named 'debugpy'

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 14, 2021

comment:12

Same issue, fixed by this ticket. Needs review

@strogdon
Copy link

comment:13

Replying to @mkoeppe:

Same issue, fixed by this ticket. Needs review

The updated dependencies for ipykernel do allow the docs to build.

@dimpase
Copy link
Member

dimpase commented Sep 14, 2021

Reviewer: Dima Pasechnik

@dimpase
Copy link
Member

dimpase commented Sep 14, 2021

comment:14

lgtm

@vbraun
Copy link
Member

vbraun commented Sep 19, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants