Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove useless 'file is not empty' comments from __init__.py files #32506

Closed
mkoeppe opened this issue Sep 12, 2021 · 8 comments
Closed

Remove useless 'file is not empty' comments from __init__.py files #32506

mkoeppe opened this issue Sep 12, 2021 · 8 comments
Labels
p: major / 3 t: enhancement t: refactoring
Milestone
sage-9.5

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Sep 12, 2021

This is for #32501 and will make it easier to see which of the __init__.py files have an actual content.

Having this comment there appears to have been a workaround for hg, which is now irrelevant.

CC: @tscrim @fchapoton

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: 1c106cd

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/32506
@mkoeppe mkoeppe added this to the sage-9.5 milestone Sep 12, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 12, 2021

Branch: u/mkoeppe/remove_useless__file_is_not_empty__comments_from___init___py_files

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 12, 2021

Commit: 1c106cd

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 12, 2021

New commits:

1c106cdRemove useless 'file is not empty' comments from __init__.py files

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 12, 2021

Author: Matthias Koeppe

@fchapoton
Copy link
Contributor

comment:3

ok

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 12, 2021

comment:4

Thanks

@vbraun
Copy link
Member

vbraun commented Sep 19, 2021

Changed branch from u/mkoeppe/remove_useless__file_is_not_empty__comments_from___init___py_files to 1c106cd

@vbraun vbraun closed this as completed in 95c863c Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-9.5
Development

No branches or pull requests
3 participants
@vbraun @fchapoton @mkoeppe