Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some .all imports #32591

Closed
mkoeppe opened this issue Sep 30, 2021 · 9 comments
Closed

Remove some .all imports #32591

mkoeppe opened this issue Sep 30, 2021 · 9 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Sep 30, 2021

(cherry-picked from #32432)

Depends on #32534

CC: @kliem @tscrim

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: 5f1c296

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/32591

@mkoeppe mkoeppe added this to the sage-9.5 milestone Sep 30, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 30, 2021

Branch: u/mkoeppe/remove_some__all_imports

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 30, 2021

Last 10 new commits:

b693d89git grep -l 'all import vector' src/sage | xargs sed -i.bak 's/sage[.]modules[.]all import vector *$/sage.modules.free_module_element import vector/'
8e357e1git grep -l 'all import matrix' src/sage | xargs sed -i.bak 's/sage[.]matrix[.]all import matrix *$/sage.matrix.constructor import matrix/'
d070bffgit grep -l 'all import RDF' src/sage | xargs sed -i.bak 's/sage[.]rings[.]all import RDF *$/sage.rings.real_double import RDF/'
2344514git grep -l 'all import SR' src/sage | xargs sed -i.bak 's/sage.*[.]all import SR *$/sage.symbolic.ring import SR/'
b552ee8src/sage/geometry: Remove remaining imports from sage.all, sage.{rings,modules,misc,categories,matrix}.all
525c860Merge #32386
d3bf6b6Merge #32534
7a63b9csage.modules.fg_pid: Replace .all imports by more specific imports
245d726src/sage/structure/sage_object.pyx: Replace import from sage.misc.all by more specific import
5f1c296src/sage/misc/sage_unittest.py: Import loads, dumps from sage.misc.persist

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 30, 2021

Commit: 5f1c296

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 30, 2021

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 30, 2021

Dependencies: #32534

@tscrim
Copy link
Collaborator

tscrim commented Sep 30, 2021

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Sep 30, 2021

comment:3

Green bot => positive review.

At the very least, this will likely help deal with Sage's import hell.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 30, 2021

comment:4

Thank you!

The pyflakes warnings are unrelated to the changes

@vbraun
Copy link
Member

vbraun commented Oct 13, 2021

Changed branch from u/mkoeppe/remove_some__all_imports to 5f1c296

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants