Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pynac: Replace direct use of singular's libfactory by a Python call #32613

Open
mkoeppe opened this issue Oct 2, 2021 · 0 comments
Open

pynac: Replace direct use of singular's libfactory by a Python call #32613

mkoeppe opened this issue Oct 2, 2021 · 0 comments
Labels
c: symbolics p: major / 3 t: enhancement

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Oct 2, 2021

pynac has a dependency on libfactory's CanonicalForm class, for polynomial factorization, expansion, gcd, resultant.

We should replace this by a callback to a Python function.

$ git grep factory/factory src/sage/symbolic/
src/sage/symbolic/expression.pyx:#   factory/factory.h    so this ^ is needed to find it
src/sage/symbolic/ginac/mpoly-singular.cpp:#include "factory/factory.h"
src/sage/symbolic/ginac/numeric.cpp:#include "factory/factory.h"

Component: symbolics

Issue created by migration from https://trac.sagemath.org/ticket/32613
@mkoeppe mkoeppe added this to the sage-9.5 milestone Oct 2, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Dec 14, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.6, sage-9.7 Mar 5, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.7, sage-9.8 Aug 31, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.8, sage-9.9 Jan 7, 2023
@mkoeppe mkoeppe removed this from the sage-10.0 milestone Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: symbolics p: major / 3 t: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mkoeppe