Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace imports of QQ, ZZ, GF, Integer from sage.rings.all by more specific imports #32620

Closed
mkoeppe opened this issue Oct 4, 2021 · 9 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Oct 4, 2021

(cherry-picked from #32432)

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: d9dd2d0

Reviewer: Jonathan Kliem

Issue created by migration from https://trac.sagemath.org/ticket/32620

@mkoeppe mkoeppe added this to the sage-9.5 milestone Oct 4, 2021
@mkoeppe mkoeppe changed the title Remove imports of QQ, ZZ, GF, Integer from sage.rings.alll Replace imports of QQ, ZZ, GF, Integer from sage.rings.all by more specific imports Oct 4, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 4, 2021

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 4, 2021

Commit: d9dd2d0

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 4, 2021

New commits:

f7e07bfgit grep -l 'all import ZZ' src/sage | xargs sed -E -i.bak $'s/^( *)from sage.*all import (ZZ, QQ|QQ, ZZ) *$/\1from sage.rings.integer_ring import ZZ\\n\1from sage.rings.rational_field import QQ/'
acf7ae9git grep -l 'all import ZZ' src/sage | xargs sed -E -i.bak $'s/^( *)from sage.*all import ZZ *$/\1from sage.rings.integer_ring import ZZ/'
31e17a4git grep -l 'all import .*ZZ' src/sage | xargs sed -E -i.bak $'s/^( *)from sage.*all import (ZZ, GF) *$/\1from sage.rings.integer_ring import ZZ\\n\1from sage.rings.finite_rings.finite_field_constructor import GF/'
d9dd2d0git grep -l 'all import.*ZZ' src/sage | xargs sed -E -i.bak $'s/^( *)from sage.*all import (ZZ, QQ|QQ, ZZ) *$/\1from sage.rings.integer_ring import ZZ\\n\1from sage.rings.rational_field import QQ/'

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 4, 2021

Author: Matthias Koeppe

@mkoeppe

This comment has been minimized.

@kliem
Copy link
Contributor

kliem commented Oct 4, 2021

comment:5

LGTM. Green bot -> Positive Review.

@kliem
Copy link
Contributor

kliem commented Oct 4, 2021

Reviewer: Jonathan Kliem

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 4, 2021

comment:6

Thank you!

@vbraun
Copy link
Member

vbraun commented Oct 13, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants