Replace sage.doctest.external.has_* functions by Features #32649

mkoeppe · 2021-10-07T18:29:08Z

Some of them already go through features - for those we just rename the feature so that its name attribute is equal to the intended "optional" tag.

For the remaining ones, we add new Feature subclasses in new files src/sage/features/internet.py, mip_backends.py.

Follow-ups:

sage.misc.latex: Replace have_... functions by Features #32650 latex.py,
Features for interpreter interfaces #32866 interfaces.py,
doctests: Detect "safe" external features even if "--optional=external" is not used #32174, in which we can deprecate the has_... functions

Depends on #30887
Depends on #32614

CC: @kwankyu @jhpalmieri @seblabbe @dimpase @jdemeyer @saraedum @tscrim @dcoudert @sagetrac-tmonteil @videlec

Component: refactoring

Author: Matthias Koeppe, Kwankyu Lee

Branch: 1d02bd0

Reviewer: Kwankyu Lee, Matthias Koeppe, Sébastien Labbé

Issue created by migration from https://trac.sagemath.org/ticket/32649

The text was updated successfully, but these errors were encountered:

mkoeppe · 2021-10-07T19:02:34Z

Branch: u/mkoeppe/replace_sage_doctest_external_has___functions_by_features

mkoeppe · 2021-10-07T19:02:52Z

New commits:

`1c6335a`	`sage.doctest.external.has_internet: Refactor through new Feature`

mkoeppe · 2021-10-07T19:02:52Z

Commit: 1c6335a

mkoeppe · 2021-10-07T19:02:52Z

Author: Matthias Koeppe, ...

mkoeppe · 2021-10-07T19:32:31Z

Dependencies: #30887

sagetrac-git · 2021-10-07T19:47:16Z

Changed commit from 1c6335a to 0c012f7

sagetrac-git · 2021-10-07T19:47:16Z

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

`5c23cc9`	`DocTestReporter: Fix 'sage -t --optional=all'`
`1b8634d`	`sage.doctest.external: Add 4ti2`
`d9d4f99`	`Merge tag '9.4.beta6' into t/30887/public/30887`
`646e182`	src/sage/features/four_ti_2.py: Move import of SAGE_ENV inside the `__init__` method, to remove confusion of sage.misc.dev_tools
`f0c61f7`	`Merge #30887`
`b7f7903`	`sage.features.graphviz: Make .name lowercase to match optional tag; refactor through JoinFeature`
`2c95e70`	`sage.features.pandoc: Make .name lowercase to match optional tag`
`214fa89`	`sage.features.ffmpeg: Make .name lowercase to match optional tag`
`eb8f637`	`sage.features.imagemagick: Make .name 'imagemagick' to match optional tag via JoinFeature`
`0c012f7`	`sage.features.rubiks: Make .name lowercase to match optional tag; refactor through JoinFeature`

sagetrac-git · 2021-10-07T19:55:38Z

Changed commit from 0c012f7 to 0321b5e

sagetrac-git · 2021-10-07T19:55:38Z

Branch pushed to git repo; I updated commit sha1. New commits:

`0321b5e`	`src/sage/features/rubiks.py: Fixup`

sagetrac-git · 2021-10-07T22:11:49Z

Changed commit from 0321b5e to 1bba486

sagetrac-git · 2021-10-07T22:11:49Z

Branch pushed to git repo; I updated commit sha1. New commits:

`1bba486`	`src/sage/features: Change remaining features to make .name equal to the optional tag`

sagetrac-git · 2021-10-07T22:21:13Z

Branch pushed to git repo; I updated commit sha1. New commits:

`d7bd9c4`	`src/sage/features/gap.py: Set .name of a GapPackage feature as gap_package_PACKAGE`

sagetrac-git · 2021-10-07T22:21:13Z

Changed commit from 1bba486 to d7bd9c4

sagetrac-git · 2021-10-07T22:26:34Z

Changed commit from d7bd9c4 to 9ee3243

sagetrac-git · 2021-10-07T22:26:34Z

Branch pushed to git repo; I updated commit sha1. New commits:

`9ee3243`	`Feature: Add documentation`

sagetrac-git · 2021-10-07T23:13:28Z

Branch pushed to git repo; I updated commit sha1. New commits:

`50248ed`	`sage.doctest.external.has_{cplex,gurobi}: Refactor through new Features`

sagetrac-git · 2021-10-07T23:13:28Z

Changed commit from 9ee3243 to 50248ed

mkoeppe · 2021-10-07T23:44:09Z

Changed author from Matthias Koeppe, ... to Matthias Koeppe

mkoeppe · 2021-10-08T01:48:18Z

Changed dependencies from #30887 to #30887, #32614

sagetrac-git · 2021-10-08T01:48:51Z

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

`66cf3e1`	`src/sage/doctest/control.py: Fixup handling of sage_optional_tags`
`1ec0c48`	`src/sage/features/sagemath.py: Add sage.rings.number_field`
`0063749`	`src/sage/features/sagemath.py: Add features for modules that were optional extensions`
`14fd1e5`	`src/doc/en/developer/coding_basics.rst: Update discussion of feature tags`
`27c53ac`	`src/sage/features/sagemath.py: Add 'sage.plot'`
`180e31d`	`Merge #30887`
`10e8d63`	`sage.features.sagemath: Use JoinFeature when tag is different from the actually tested module`
`654d09c`	`sage.features.sagemath: Change sage_optional_tags to sage_features`
`f63a7d0`	`src/sage/features/: Move features depending on optional packages to separate files`
`9358502`	`Merge #32614`

sagetrac-git · 2021-10-08T01:48:51Z

Changed commit from 50248ed to 9358502

sagetrac-git · 2021-10-08T01:55:23Z

Changed commit from 9358502 to 6457ee9

seblabbe · 2021-10-15T10:15:18Z

comment:38

Looks good now, that is, I get All tests passed with sage -btp --optional=sage,optional,external,build src/sage/features/ now.

seblabbe · 2021-10-15T10:15:18Z

Changed reviewer from Kwankyu Lee, Matthias Koeppe to Kwankyu Lee, Matthias Koeppe, Sébastien Labbé

mkoeppe · 2021-10-15T16:18:26Z

comment:39

Thanks for reviewing!

seblabbe · 2021-10-15T18:16:29Z

comment:40

Oups, is it too late to put it back to "needs work"? Because patchbot pyflakes says:

src/sage/doctest/external.py:38:1 'urllib.error' imported but unused
src/sage/doctest/external.py:39:1 'urllib.request.Request' imported but unused
src/sage/doctest/external.py:39:1 'urllib.request.urlopen' imported but unused
src/sage/doctest/external.py:40:1 'ssl.SSLContext' imported but unused

src/sage/features/graphviz.py:14:1 '.Feature' imported but unused
src/sage/features/graphviz.py:14:1 '.FeatureTestResult' imported but unused

src/sage/features/latte.py:5:1 '.Feature' imported but unused
src/sage/features/latte.py:5:1 '.FeatureTestResult' imported but unused

src/sage/features/rubiks.py:12:1 '.Feature' imported but unused
src/sage/features/rubiks.py:12:1 '.FeatureTestResult' imported but unused

found 10 pyflakes errors in the modified files
pyflakes -- 0 seconds

Also

========== coverage ==========
git checkout patchbot/ticket_merged
Full doctests in features/internet.py: 2 / 2 = 100%
Missing doctests in features/mcqd.py: 0 / 1 = 0%
Missing doctests in features/meataxe.py: 0 / 1 = 0%
Missing doctests in features/mip_backends.py: 0 / 4 = 0%
Missing doctests in features/sagemath.py: 1 / 7 = 14%
Missing doctests in features/tdlib.py: 0 / 1 = 0%
Coverage went from 50872 / 52638 = 96.645% to 50873 / 52652 = 96.621%
====================

sagetrac-git · 2021-10-15T20:07:20Z

Changed commit from 08248a1 to 759c88b

sagetrac-git · 2021-10-15T20:07:20Z

Branch pushed to git repo; I updated commit sha1. New commits:

`759c88b`	`sage.doctest, sage.control: Remove unused imports`

sagetrac-git · 2021-10-15T20:16:20Z

Branch pushed to git repo; I updated commit sha1. New commits:

`74e5c9c`	`src/sage/features/mcqd.py: Add doctests`

sagetrac-git · 2021-10-15T20:16:20Z

Changed commit from 759c88b to 74e5c9c

sagetrac-git · 2021-10-15T20:16:44Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`15729dc`	`src/sage/features/mcqd.py: Add doctests`

sagetrac-git · 2021-10-15T20:16:44Z

Changed commit from 74e5c9c to 15729dc

mkoeppe · 2021-10-15T20:17:54Z

comment:45

Here are some fixes for these style warnings, contributions welcome

sagetrac-git · 2021-10-16T03:47:36Z

Branch pushed to git repo; I updated commit sha1. New commits:

`1d02bd0`	`More doctests for coverage`

sagetrac-git · 2021-10-16T03:47:36Z

Changed commit from 15729dc to 1d02bd0

kwankyu · 2021-10-16T03:50:02Z

comment:47

Added more doctests to make bots happy. I could not run tests for numerical backends (cplex, gurobi, coin) because I failed to install them.

mkoeppe · 2021-10-16T03:55:48Z

comment:48

Thank you! I'll test it with the coin backend.

vbraun · 2021-10-20T23:01:01Z

Changed branch from public/32649 to 1d02bd0

mkoeppe · 2021-11-13T18:35:46Z

Changed commit from 1d02bd0 to none

mkoeppe added this to the sage-9.5 milestone Oct 7, 2021

mkoeppe added t: refactoring labels Oct 7, 2021

This comment has been minimized.

Sign in to view

mkoeppe added the s: needs review label Oct 7, 2021

kwankyu added s: needs review and removed s: needs work labels Oct 15, 2021

seblabbe added s: positive review and removed s: needs review labels Oct 15, 2021

mkoeppe added s: needs work and removed s: positive review labels Oct 15, 2021

mkoeppe added s: needs review and removed s: needs work labels Oct 15, 2021

mkoeppe added s: positive review and removed s: needs review labels Oct 16, 2021

vbraun removed the s: positive review label Oct 20, 2021

vbraun closed this as completed in e7f6b13 Oct 20, 2021

This comment has been minimized.

Sign in to view

Replace sage.doctest.external.has_* functions by Features #32649

Replace sage.doctest.external.has_* functions by Features #32649

Comments

mkoeppe commented Oct 7, 2021

This comment has been minimized.

mkoeppe commented Oct 7, 2021

mkoeppe commented Oct 7, 2021

mkoeppe commented Oct 7, 2021

mkoeppe commented Oct 7, 2021

mkoeppe commented Oct 7, 2021

sagetrac-git mannequin commented Oct 7, 2021

sagetrac-git mannequin commented Oct 7, 2021

sagetrac-git mannequin commented Oct 7, 2021

sagetrac-git mannequin commented Oct 7, 2021

This comment has been minimized.

sagetrac-git mannequin commented Oct 7, 2021

sagetrac-git mannequin commented Oct 7, 2021

sagetrac-git mannequin commented Oct 7, 2021

sagetrac-git mannequin commented Oct 7, 2021

sagetrac-git mannequin commented Oct 7, 2021

sagetrac-git mannequin commented Oct 7, 2021

sagetrac-git mannequin commented Oct 7, 2021

sagetrac-git mannequin commented Oct 7, 2021

mkoeppe commented Oct 7, 2021

This comment has been minimized.

mkoeppe commented Oct 8, 2021

sagetrac-git mannequin commented Oct 8, 2021

sagetrac-git mannequin commented Oct 8, 2021

sagetrac-git mannequin commented Oct 8, 2021

seblabbe commented Oct 15, 2021

seblabbe commented Oct 15, 2021

mkoeppe commented Oct 15, 2021

seblabbe commented Oct 15, 2021

sagetrac-git mannequin commented Oct 15, 2021

sagetrac-git mannequin commented Oct 15, 2021

sagetrac-git mannequin commented Oct 15, 2021

sagetrac-git mannequin commented Oct 15, 2021

sagetrac-git mannequin commented Oct 15, 2021

sagetrac-git mannequin commented Oct 15, 2021

mkoeppe commented Oct 15, 2021

sagetrac-git mannequin commented Oct 16, 2021

sagetrac-git mannequin commented Oct 16, 2021

kwankyu commented Oct 16, 2021

mkoeppe commented Oct 16, 2021

vbraun commented Oct 20, 2021

This comment has been minimized.

mkoeppe commented Nov 13, 2021