Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sage.rings.abc.{AlgebraicField,...,NumberField_quadratic}, deprecate is_AlgebraicField, ..., is_CyclotomicField, is_QuadraticField #32660

Closed
mkoeppe opened this issue Oct 10, 2021 · 20 comments
Closed

Add sage.rings.abc.{AlgebraicField,...,NumberField_quadratic}, deprecate is_AlgebraicField, ..., is_CyclotomicField, is_QuadraticField #32660

mkoeppe opened this issue Oct 10, 2021 · 20 comments
Labels
p: major / 3 t: enhancement t: refactoring
Milestone
sage-9.5

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Oct 10, 2021

Part of meta-ticket #32414.

Depends on #32612

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: 3643052

Reviewer: Jonathan Kliem

Issue created by migration from https://trac.sagemath.org/ticket/32660
@mkoeppe mkoeppe added this to the sage-9.5 milestone Oct 10, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 10, 2021

Changed dependencies from #32566 to #32612

@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 16, 2021

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 16, 2021

Branch: u/mkoeppe/add_sage_rings_abc_algebraicfield_etc___deprecate_is_algebraicfield

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 16, 2021

Commit: a990a14

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 16, 2021

Last 10 new commits:

1b0a5absrc/sage/modules/vector_space_morphism.py: Do not fail if sage.symbol is not present
83b5038src/sage/modules/free_module_element.pyx: Move import from sage.misc.derivative into method
acca6c2src/sage/matrix/matrix2.pyx: Move import from sage.misc.derivative into method
907b57cMerge #32593
355dbcbMerge #32606
fb56937Merge tag '9.5.beta3' into t/32610/deprecate_is_realfield__is_complexfield__is_realdoublefield__is_complexdoublefield
8cc3500src/sage/rings/polynomial/polynomial_singular_interface.py: Fixup merge
124f213Merge #32610
d60b10dMerge #32612
a990a14Add sage.rings.abc.AlgebraicField etc., deprecate is_AlgebraicField

@mkoeppe mkoeppe changed the title Add sage.rings.abc.AlgebraicField etc., deprecate is_AlgebraicField Add sage.rings.abc.{AlgebraicField,...,NumberField_quadratic}, deprecate is_AlgebraicField, ..., is_QuadraticField Oct 16, 2021
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 16, 2021

Changed commit from a990a14 to 8d74803

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 16, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

8d74803Add sage.rings.abc.NumberField_quadratic, deprecate is_QuadraticField

@mkoeppe mkoeppe changed the title Add sage.rings.abc.{AlgebraicField,...,NumberField_quadratic}, deprecate is_AlgebraicField, ..., is_QuadraticField Add sage.rings.abc.{AlgebraicField,...,NumberField_quadratic}, deprecate is_AlgebraicField, ..., is_CyclotomicField, is_QuadraticField Oct 16, 2021
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 16, 2021

Changed commit from 8d74803 to f4369f5

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 16, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

f4369f5Add sage.rings.abc.NumberField_cyclotomic, deprecate is_CyclotomicField

@mkoeppe

This comment has been minimized.

Sign in to view
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 17, 2021

Changed commit from f4369f5 to eac6303

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 17, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

eac6303src/sage/interfaces/polymake.py: Add missing import

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 23, 2021

comment:11

The doctest failure in src/sage/rings/integer.pyx is not from this ticket.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 24, 2021

Changed commit from eac6303 to 3643052

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 24, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

2e2d1feMerge tag '9.5.beta4' into t/32660/add_sage_rings_abc_algebraicfield_etc___deprecate_is_algebraicfield
3643052src/sage/rings/abc.pyx: Restore lost RealField

@kliem
Copy link
Contributor

kliem commented Oct 25, 2021

comment:13

LGTM.

@kliem
Copy link
Contributor

kliem commented Oct 25, 2021

Reviewer: Jonathan Kliem

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 25, 2021

comment:14

Thank you!

@vbraun
Copy link
Member

vbraun commented Oct 28, 2021

Changed branch from u/mkoeppe/add_sage_rings_abc_algebraicfield_etc___deprecate_is_algebraicfield to 3643052

@vbraun vbraun closed this as completed in bac0d56 Oct 28, 2021
mkoeppe added a commit to mkoeppe/sage that referenced this issue Feb 12, 2023
@mkoeppe
Merge sagemath#32660
a776def
mkoeppe added a commit to mkoeppe/sage that referenced this issue Sep 21, 2023
@mkoeppe
src/sage/rings/number_field/number_field.py: Remove functions depreca…
851468f 
…ted in sagemath#32660 (2021)
vbraun pushed a commit to vbraun/sage that referenced this issue Sep 23, 2023
sagemathgh-36307: sage.rings: Remove code deprecated in sagemath#23204
9ea5127 
, sagemath#24483, sagemath#24371, sagemath#24511, sagemath#25848, sagemath#26105, sagemath#28481, sagemath#29010, sagemath#29412, sagemath#30332, sagemath#30372, sagemath#31345, sagemath#32375, sagemath#32606, sagemath#32610, sagemath#32612, sagemath#32641, sagemath#32660, sagemath#32750, sagemath#32869, sagemath#33602

    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36307
Reported by: Matthias Köppe
Reviewer(s):
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-9.5
Development

No branches or pull requests
3 participants
@vbraun @mkoeppe @kliem