-
-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move sage.functions.other.sqrt to sage.misc.functional #32717
Milestone
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Commit: |
Author: Matthias Koeppe |
This comment has been minimized.
This comment has been minimized.
comment:8
The failure in |
mkoeppe
changed the title
Remove use of sage.functions.other.sqrt (outside of sage.symbolic, sage.functions, sage.manifolds)
Move sage.functions.other.sqrt to sage.misc.functional
Oct 20, 2021
comment:10
LGTM. |
Reviewer: Travis Scrimshaw |
comment:11
Thanks! |
mkoeppe
added a commit
to mkoeppe/sage
that referenced
this issue
Feb 12, 2023
mkoeppe
added a commit
to mkoeppe/sage
that referenced
this issue
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
$ git grep 'functions.*import.*sqrt'
finds a small number of these importssqrt
is actually not a symbolic function, so we move it tosage.misc.functional
and import it from there.isqrt
already lives there.(Alternatively, many uses of the
sqrt
function could be replaced by a call to the.sqrt
method.)Either way will avoid the dependency on
sage.symbolic
.(Same for
ceil
,floor
, but that could also be done via #25827.)CC: @tscrim
Component: refactoring
Author: Matthias Koeppe
Branch/Commit:
451ac27
Reviewer: Travis Scrimshaw
Issue created by migration from https://trac.sagemath.org/ticket/32717
The text was updated successfully, but these errors were encountered: