Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation of sage.features #32925

Closed
mkoeppe opened this issue Nov 23, 2021 · 13 comments
Closed

Improve documentation of sage.features #32925

mkoeppe opened this issue Nov 23, 2021 · 13 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Nov 23, 2021

We also change the sporadic use of # optional: FEATURE by the more common # optional - FEATURE.

Depends on #32866
Depends on #32174

CC: @seblabbe @saraedum @kwankyu @slel

Component: documentation

Author: Matthias Koeppe

Branch/Commit: 547206c

Reviewer: Sébastien Labbé

Issue created by migration from https://trac.sagemath.org/ticket/32925

@mkoeppe mkoeppe added this to the sage-9.5 milestone Nov 23, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 23, 2021

Changed dependencies from #32866 to #32866, #32174

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 23, 2021

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 23, 2021

Commit: d364333

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 23, 2021

Last 10 new commits:

12a2507src/sage/features/interfaces.py: Fix indentation in docstring
32dc210Merge #32174
b8eb3ffsrc/doc/en/reference/misc/index.rst: Move sage/features from 'Interactive' to 'Programming Utilities'
322e7c9sage.features: Add headers for the reference manual
0b26010src/doc/en/reference/misc/index.rst: Add sage.features.interfaces
dc954a7src/sage/features/__init__.py: Fix doc markup
fe05309sage.features.pkg_systems: New, move PackageSystem and subclasses here
b7cd28esage.features.sagemath: Improve docstring markup
bd59980sage.features.mip_backends: Improve doc markup
d364333sage.features: Improve doc markup

@slel
Copy link
Member

slel commented Nov 26, 2021

comment:5

Some optional doctests are marked # optional: blah,
rather than # optional - blah as in the developer guide,
not sure whether that matters at all.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 26, 2021

comment:6

git grep 'sage:.*# *optional.*:' shows that both styles are used in the Sage library, but I think it's a good idea to make it uniform

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 26, 2021

Changed commit from d364333 to 547206c

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 26, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

547206cChange "# optional: FEATURE" to "# optional - FEATURE"

@mkoeppe

This comment has been minimized.

@seblabbe
Copy link
Contributor

seblabbe commented Dec 1, 2021

Reviewer: Sébastien Labbé

@seblabbe
Copy link
Contributor

seblabbe commented Dec 1, 2021

comment:9

Works for me. Patchbot confirms that the documentation build fine.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 1, 2021

comment:10

Thank you!

@vbraun
Copy link
Member

vbraun commented Dec 19, 2021

Changed branch from u/mkoeppe/improve_documentation_of_sage_features to 547206c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants