Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deactivate the u-prefix doctest handler #32938

Closed
fchapoton opened this issue Nov 26, 2021 · 21 comments
Closed

Deactivate the u-prefix doctest handler #32938

fchapoton opened this issue Nov 26, 2021 · 21 comments

Comments

@fchapoton
Copy link
Contributor

... that remains from the transition py2/py3.

Depends on #32935
Depends on #32934
Depends on #32941

CC: @slel

Component: refactoring

Keywords: unicode

Author: Frédéric Chapoton

Branch/Commit: 4c0d6e9

Reviewer: Michael Orlitzky

Issue created by migration from https://trac.sagemath.org/ticket/32938

@fchapoton fchapoton added this to the sage-9.5 milestone Nov 26, 2021
@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/32938

@fchapoton
Copy link
Contributor Author

Commit: 166b040

@fchapoton
Copy link
Contributor Author

New commits:

272c0cdremoving the unicode scaffolding in doctest parsing
166b040trying to desactive the handling of unicode prefix u in doctests

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 26, 2021

Changed commit from 166b040 to b0a85c3

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 26, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

b0a85c3more removal of unicode u prefix in doctests

@fchapoton

This comment has been minimized.

@fchapoton
Copy link
Contributor Author

Changed dependencies from #32935,#32934 to #32935,#32934,#32941

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 16, 2021

comment:5

Also the import of cython_strip_string_literals should be removed

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 29, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

71a387bMerge branch 'u/chapoton/32938' in 9.5.b9
13cff57remove import

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 29, 2021

Changed commit from b0a85c3 to 13cff57

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 30, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

4c0d6e9fix doctests

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 30, 2021

Changed commit from 13cff57 to 4c0d6e9

@fchapoton
Copy link
Contributor Author

comment:11

bot is now green, linter is broken, so ticket is ready for review

@fchapoton

This comment has been minimized.

@orlitzky
Copy link
Contributor

Reviewer: Michael Orlitzky

@orlitzky
Copy link
Contributor

comment:13

Looks reasonable, thanks.

@orlitzky orlitzky changed the title desactivation of the u-prefix doctest handler deactivation of the u-prefix doctest handler Dec 30, 2021
@slel

This comment has been minimized.

@slel
Copy link
Member

slel commented Jan 1, 2022

comment:14

In src/sage/doctest/parsing.py, do the examples under

Tolerance on Python 3 for string results with unicode prefix::

still make sense?

@slel
Copy link
Member

slel commented Jan 1, 2022

Changed keywords from none to unicode

@slel slel changed the title deactivation of the u-prefix doctest handler Deactivate the u-prefix doctest handler Jan 1, 2022
@slel
Copy link
Member

slel commented Jan 1, 2022

comment:15

In src/sage/typeset/character_art_factory.py,
does this test still make sense?

    sage: from sage.typeset.ascii_art import _ascii_art_factory as factorysage: 
    factory.build_from_string('à\nbb\nccc')  # same with unicode
    à
    bb
    ccc
 

@vbraun
Copy link
Member

vbraun commented Jan 4, 2022

Changed branch from u/chapoton/32938 to 4c0d6e9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants