Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cython: Update to 0.29.25 #32985

Closed
mkoeppe opened this issue Dec 6, 2021 · 22 comments
Closed

cython: Update to 0.29.25 #32985

mkoeppe opened this issue Dec 6, 2021 · 22 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 6, 2021

https://cython.readthedocs.io/en/latest/src/changes.html#id24

CC: @orlitzky @slel @antonio-rojas

Component: packages: standard

Author: Matthias Koeppe

Branch: 8ef52be

Reviewer: François Bissey

Issue created by migration from https://trac.sagemath.org/ticket/32985

@mkoeppe mkoeppe added this to the sage-9.5 milestone Dec 6, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 7, 2021

Branch: u/mkoeppe/cython__update_to_0_29_25

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 7, 2021

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 7, 2021

Commit: 8ef52be

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 7, 2021

New commits:

fb6cb4dbuild/pkgs/cython: Update to 0.29.25
8ef52bebuild/pkgs/cython: Remove upstreamed patch

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 7, 2021

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 9, 2021

comment:4

Is the failure on archlinux (https://github.com/mkoeppe/sage/runs/4439212188?check_suite_focus=true) coming from this ticket?

@kiwifb
Copy link
Member

kiwifb commented Dec 9, 2021

comment:5

Replying to @mkoeppe:

Is the failure on archlinux (https://github.com/mkoeppe/sage/runs/4439212188?check_suite_focus=true) coming from this ticket?

I doubt it. sage-on-gentoo works perfectly with this ticket and if it wasn't for troubles with the latest giac I would have a perfect doctest run now.

@antonio-rojas
Copy link
Contributor

comment:6

Replying to @mkoeppe:

Is the failure on archlinux (https://github.com/mkoeppe/sage/runs/4439212188?check_suite_focus=true) coming from this ticket?

I still have no idea how to inspect the logs, unfortunately. The last few lines of the sagelib build summary don't include the actual error, and if I click "View raw logs" or "Download log archive" I only get the same summary again in plain text.

@sheerluck
Copy link
Contributor

comment:7

Replying to @antonio-rojas:

I still have no idea how to inspect the logs

search https://github.com/mkoeppe/sage/actions/runs/1547718702 for "archlinux-latest-standard", find artifact logs-commit-8aa40cca77cd5a44c3d370e1eebbbad46bc3546e-tox-docker-archlinux-latest-standard, unzip downloaded file and search logs/pkgs/sagelib-9.5.beta7.log for "multi_polynomial_ideal_libsingular":

build/cythonized/sage/rings/polynomial/multi_polynomial_ideal_libsingular.cpp: In function ‘PyObject* __pyx_pf_4sage_5rings_10polynomial_34multi_polynomial_ideal_libsingular_6interred_libsingular(PyObject*, PyObject*)’:
build/cythonized/sage/rings/polynomial/multi_polynomial_ideal_libsingular.cpp:5142:30: error: cannot convert ‘ip_sring*’ to ‘coeffs’ {aka ‘n_Procs_s*’} 5142 |       n_Delete((&__pyx_v_n), __pyx_v_r);
      |                              ^~~~~~~~~
      |                              |
      |                              ip_sring*
In file included from /usr/include/singular/polys/monomials/ring.h:12,
                 from /usr/include/singular/kernel/polys.h:15,
                 from /usr/include/singular/kernel/structs.h:25,
                 from /usr/include/singular/Singular/libsingular.h:7,
                 from build/cythonized/sage/rings/polynomial/multi_polynomial_ideal_libsingular.cpp:746:

@antonio-rojas
Copy link
Contributor

comment:8

Thanks. So that would be sage picking up system singular 4.2.1.p2 while not including #32907 yet.

@antonio-rojas
Copy link
Contributor

comment:9

Replying to @sheerluck:

find artifact logs-commit-8aa40cca77cd5a44c3d370e1eebbbad46bc3546e-tox-docker-archlinux-latest-standard

This is what I can't figure out. Where/how do I find those artifacts?

@sheerluck
Copy link
Contributor

comment:10

Replying to @antonio-rojas:

Where/how do I find those artifacts?

They are not on the page for archlinux (runs/4439212188) you get after you click column on the left, they are on "main" page (runs/1547718702) you get after you click Run SAGE_ROOT/tox.ini from https://github.com/mkoeppe/sage/actions

That is a strange Github Actions thing, I guess ¯_(ツ)_/¯

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 9, 2021

comment:11

Then let's get this ticket in please

@kiwifb
Copy link
Member

kiwifb commented Dec 9, 2021

comment:12

Works for me :)

@kiwifb
Copy link
Member

kiwifb commented Dec 9, 2021

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 9, 2021

comment:13

Thanks!

@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Jan 10, 2022
@slel
Copy link
Member

slel commented Jan 12, 2022

comment:15

Cython 0.29.26 was released.

@slel
Copy link
Member

slel commented Jan 30, 2022

comment:16

Maybe upgrade to Cython 0.29.27?

Or leave that for a follow-up ticket.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 30, 2022

comment:17

Follow-up ticket please

@vbraun
Copy link
Member

vbraun commented Jan 31, 2022

Changed branch from u/mkoeppe/cython__update_to_0_29_25 to 8ef52be

@vbraun vbraun closed this as completed in f0df3d8 Jan 31, 2022
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 6, 2022

comment:19

Next update in #33305

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 6, 2022

Changed commit from 8ef52be to none

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants