-
-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meta-ticket: Remove use of SAGE_LIB and SAGE_EXTCODE variables #33037
Comments
This comment has been minimized.
This comment has been minimized.
comment:2
This could have some interesting consequences. At the moment So those things may have to be thought about while removing that variable. |
comment:3
It should also depend on the work on extcode, from
|
This comment has been minimized.
This comment has been minimized.
Dependencies: #31306 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…GE_EXTCODE deprecation
…GE_EXTCODE deprecation
…GE_EXTCODE deprecation
…GE_EXTCODE deprecation
…GE_EXTCODE deprecation
Topics here: - ext_data is legacy location only, see sagemath#33037 - separate repos for large data files - importlib_resources Follow-ups: - use of Features <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#37399 Reported by: Matthias Köppe Reviewer(s): gmou3, Gonzalo Tornaría, Matthias Köppe, Sebastian Oehms
Portions of namespace packages can be installed in separate locations.
Hence, the variable
sage.env.SAGE_LIB
is no longer meaningful.Instead, we should make use of the
__path__
attribute of packages, https://python.readthedocs.io/en/stable/reference/import.html#module-path, which in the case of namespace packages is an iterable.Use of
SAGE_LIB
insrc/sage/misc/lazy_import_cache.py
can possibly be removed after Remove expired deprecations that use lazy_import(MODULE, "*") #33308sage -t --installed #33407
sage -t --all-installed
Remove use of SAGE_LIB in sage.misc #33821 Remove use of
SAGE_LIB
insage.misc
sage.env.sage_include_directories: Don't use distutils and SAGE_LIB #33137
sage.env.sage_include_directories
: Don't usedistutils
andSAGE_LIB
SAGE_EXTCODE
should be replaced by usingimportlib.resources
(more precisely, the backport packageimportlib-resources
). Version 5.9.0 can doas_file
with directories (https://importlib-resources.readthedocs.io/en/latest/history.html#v5-9-0)Depends on #31306
CC: @tornaria
Component: refactoring
Issue created by migration from https://trac.sagemath.org/ticket/33037
The text was updated successfully, but these errors were encountered: