-
-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
notebook: update to 6.4.10 to fix deprecation warning #33063
Comments
comment:3
On the one hand, this looks fine to me. But I also see that this has now been fixed upstream in 6.4.7 (https://github.com/jupyter/notebook/releases/tag/v6.4.7) and it would make sense to update from 6.4.6 to 6.4.7 or 6.4.8. |
comment:4
I agree, updating to the latest in the 6.4.x series is better |
Changed branch from u/tornaria/notebook-deprecation-patch to u/mkoeppe/notebook-deprecation-patch |
Changed author from Gonzalo Tornaría to Matthias Koeppe |
This comment has been minimized.
This comment has been minimized.
New commits:
|
Changed upstream from Reported upstream. No feedback yet. to Fixed upstream, in a later stable release. |
Reviewer: Dima Pasechnik |
comment:8
lgtm |
Changed branch from u/mkoeppe/notebook-deprecation-patch to |
While doctesting
src/sage/repl/ipython_kernel/install.py
:The solution is to make the regex a raw string.
Upstream: jupyter/notebook#6253
We update to the latest in the 6.4.x series, 6.4.10, which contains the fix.
Upstream: Fixed upstream, in a later stable release.
CC: @dimpase @egourgoulhon
Component: packages: standard
Author: Matthias Koeppe
Branch/Commit:
67537dd
Reviewer: Dima Pasechnik
Issue created by migration from https://trac.sagemath.org/ticket/33063
The text was updated successfully, but these errors were encountered: