Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notebook: update to 6.4.10 to fix deprecation warning #33063

Closed
tornaria opened this issue Dec 21, 2021 · 11 comments
Closed

notebook: update to 6.4.10 to fix deprecation warning #33063

tornaria opened this issue Dec 21, 2021 · 11 comments

Comments

@tornaria
Copy link
Contributor

While doctesting src/sage/repl/ipython_kernel/install.py:

DeprecationWarning: invalid escape sequence '\s'

The solution is to make the regex a raw string.

Upstream: jupyter/notebook#6253

We update to the latest in the 6.4.x series, 6.4.10, which contains the fix.

Upstream: Fixed upstream, in a later stable release.

CC: @dimpase @egourgoulhon

Component: packages: standard

Author: Matthias Koeppe

Branch/Commit: 67537dd

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/33063

@tornaria tornaria added this to the sage-9.5 milestone Dec 21, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Jan 28, 2022
@davidlowryduda
Copy link
Contributor

comment:3

On the one hand, this looks fine to me. But I also see that this has now been fixed upstream in 6.4.7 (https://github.com/jupyter/notebook/releases/tag/v6.4.7) and it would make sense to update from 6.4.6 to 6.4.7 or 6.4.8.

@mkoeppe
Copy link
Contributor

mkoeppe commented Mar 29, 2022

comment:4

I agree, updating to the latest in the 6.4.x series is better

@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 1, 2022

@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 1, 2022

Changed author from Gonzalo Tornaría to Matthias Koeppe

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 1, 2022

Changed commit from 966926e to 67537dd

@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 1, 2022

New commits:

67537ddbuild/pkgs/notebook: Update to 6.4.10

@mkoeppe mkoeppe changed the title notebook: fix deprecation warning notebook: update to 6.4.10 to fix deprecation warning Apr 1, 2022
@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 8, 2022

Changed upstream from Reported upstream. No feedback yet. to Fixed upstream, in a later stable release.

@dimpase
Copy link
Member

dimpase commented Apr 8, 2022

Reviewer: Dima Pasechnik

@dimpase
Copy link
Member

dimpase commented Apr 8, 2022

comment:8

lgtm

@vbraun
Copy link
Member

vbraun commented Apr 10, 2022

Changed branch from u/mkoeppe/notebook-deprecation-patch to 67537dd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants