Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust dochtml label so doctests pass when html doc is not built/installed #33085

Closed
tornaria opened this issue Dec 26, 2021 · 13 comments
Closed

Comments

@tornaria
Copy link
Contributor

This includes

  • sage_docbuild: fails when cache cannot be saved #33064: do not fail when docbuild cache cannot be saved
  • remove dochtml label from some tests that don't need docs installed
  • add dochtml label to some tests that need docs installed
  • use dochtml as default option only when html docs are installed

Depends on #33064

CC: @jhpalmieri

Component: doctest framework

Author: Gonzalo Tornaría

Branch/Commit: 88dd9f3

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/33085

@tornaria
Copy link
Contributor Author

Commit: 4e364ea

@tornaria
Copy link
Contributor Author

Branch: u/tornaria/dochtml

@tornaria
Copy link
Contributor Author

New commits:

a8973f2sage_docbuild: do not fail when cache cannot be saved
7d3381bdoctests: remove dochtml label from some tests that don't need docs installed
42a76c3doctests: add dochtml label to some tests that need docs installed
4e364eadoctests: use dochtml as default option only when html docs are installed

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 26, 2021

comment:2

This should be redone on top of #32759, which changes the optional tag

@jhpalmieri
Copy link
Member

comment:4

In particular with #32759, if docbuilding has been disabled, then sage_docbuild/* won't get doctested by default, so it may not need any special tags. (If someone explicitly doctests that directory, tests will fail, but if they run make ptest or similar, the files in that directory will be skipped.)

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 9, 2022

Changed commit from 4e364ea to 78063f3

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 9, 2022

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

e89193fsage_docbuild: do not fail when cache cannot be saved
18d0477doctests: remove dochtml label from some tests that don't need docs installed
78063f3doctests: add dochtml label to some tests that need docs installed

@tornaria
Copy link
Contributor Author

tornaria commented Jan 9, 2022

comment:6

Rebased to 9.5.rc0, changing dochtml tags for sagemath_doc_html.

Removed the last commit which is now unnecessary.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 9, 2022

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

88dd9f3doctests: add dochtml label to some tests that need docs installed

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 9, 2022

Changed commit from 78063f3 to 88dd9f3

@mkoeppe
Copy link
Contributor

mkoeppe commented Jan 9, 2022

comment:8

Ready for review? Looks fine to me

@mkoeppe
Copy link
Contributor

mkoeppe commented Jan 9, 2022

Reviewer: Matthias Koeppe

@vbraun
Copy link
Member

vbraun commented Feb 13, 2022

Changed branch from u/tornaria/dochtml to 88dd9f3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants