Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix references to doc-clean #33104

Closed
jhpalmieri opened this issue Jan 1, 2022 · 7 comments
Closed

Fix references to doc-clean #33104

jhpalmieri opened this issue Jan 1, 2022 · 7 comments
Labels
c: documentation p: critical / 2 t: bug
Milestone
sage-9.5

Comments

@jhpalmieri
Copy link
Member

Followup to #29310: make doc-uninstall should frequently be used instead of or in addition to make doc-clean, so the instructions for installation from source need to be fixed, as should error messages when building the docs.

Component: documentation

Author: John Palmieri

Branch/Commit: 2879f6d

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/33104
@jhpalmieri jhpalmieri added this to the sage-9.5 milestone Jan 1, 2022
@jhpalmieri jhpalmieri changed the title Fix references to doc-clean in the installation guide` Fix references to doc-clean Jan 1, 2022
@jhpalmieri

This comment has been minimized.

Sign in to view
@jhpalmieri
Copy link
Member Author

Branch: u/jhpalmieri/change-doc-clean-to-doc-uninstall

@jhpalmieri
Copy link
Member Author

New commits:

2879f6dtrac 33104: after #29310, change refererences to "make doc-clean"

@jhpalmieri
Copy link
Member Author

Commit: 2879f6d

@mkoeppe
Copy link
Contributor

mkoeppe commented Jan 1, 2022

Reviewer: Matthias Koeppe

@jhpalmieri
Copy link
Member Author

comment:7

That was quick! Thanks!

@vbraun
Copy link
Member

vbraun commented Jan 9, 2022

Changed branch from u/jhpalmieri/change-doc-clean-to-doc-uninstall to 2879f6d

@vbraun vbraun closed this as completed in 464e8c3 Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: documentation p: critical / 2 t: bug
Projects
None yet
Milestone
sage-9.5
Development

No branches or pull requests
3 participants
@vbraun @jhpalmieri @mkoeppe