Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better fix installation of cryptominisat and pycryptosat #33183

Closed
dimpase opened this issue Jan 15, 2022 · 28 comments
Closed

Better fix installation of cryptominisat and pycryptosat #33183

dimpase opened this issue Jan 15, 2022 · 28 comments
Labels
c: packages: optional p: blocker / 1 t: bug
Milestone
sage-9.5

Comments

@dimpase
Copy link
Member

dimpase commented Jan 15, 2022

a followup to #33162

Depends on #33162

CC: @mkoeppe @culler

Component: packages: optional

Author: Dima Pasechnik

Branch/Commit: 76463a8

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/33183
@dimpase dimpase added this to the sage-9.6 milestone Jan 15, 2022
@mkoeppe
Copy link
Contributor

mkoeppe commented Jan 15, 2022

Dependencies: #33162

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 15, 2022

Changed commit from e3d8e91 to c17897c

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 15, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

c17897cchecksums as link, and added install-requires

@dimpase
Copy link
Member Author

dimpase commented Jan 15, 2022

Author: Dima Pasechnik

@mkoeppe
Copy link
Contributor

mkoeppe commented Jan 15, 2022

comment:4

Doctest tags # optional - cryptominisat will have to be changed to ... pycryptosat

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 15, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

cfcf33aretag the tests: cryptominisat->pycryptosat

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 15, 2022

Changed commit from c17897c to cfcf33a

@dimpase
Copy link
Member Author

dimpase commented Jan 15, 2022

comment:6

done.

@mkoeppe
Copy link
Contributor

mkoeppe commented Jan 15, 2022

Reviewer: Matthias Koeppe

@mkoeppe
Copy link
Contributor

mkoeppe commented Jan 15, 2022

comment:8

Next, #25374?

@mkoeppe
Copy link
Contributor

mkoeppe commented Jan 17, 2022

comment:9

build/pkgs/pycryptosat/dependencies also needs $(PYTHON_TOOLCHAIN) (thanks, Marc!)

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 17, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

c0c9f5cadd $(PYTHON_TOOLCHAIN) dependency

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 17, 2022

Changed commit from cfcf33a to c0c9f5c

@mkoeppe
Copy link
Contributor

mkoeppe commented Jan 17, 2022

comment:12

should be an order-only dep

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 17, 2022

Changed commit from c0c9f5c to 9c0f513

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 17, 2022

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

9c0f513add $(PYTHON_TOOLCHAIN) dependency

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 17, 2022

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

6d4bf11add $(PYTHON_TOOLCHAIN) dependency

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 17, 2022

Changed commit from 9c0f513 to 6d4bf11

@dimpase
Copy link
Member Author

dimpase commented Jan 17, 2022

comment:15

ok, it's order-only now.

@vbraun
Copy link
Member

vbraun commented Jan 22, 2022

comment:17

Obviously none of you bothered to build & test

@mkoeppe
Copy link
Contributor

mkoeppe commented Jan 22, 2022

comment:18

Volker, it sounds like you are having some trouble there. We need to know the details so that we can help you.

@dimpase
Copy link
Member Author

dimpase commented Jan 22, 2022

comment:19

there was unwanted junk that sneaked in: build/pkgs/curl/spkg-install.in change - my fault.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 22, 2022

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

ea82e77spin off installation of cryptominisat's Python
be0b019checksums as link, and added install-requires
f834119retag the tests: cryptominisat->pycryptosat
a7bc1adadd $(PYTHON_TOOLCHAIN) dependency
e65de87revert curl change that sneaked in

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 22, 2022

Changed commit from 6d4bf11 to e65de87

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 22, 2022

Changed commit from e65de87 to 76463a8

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 22, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

76463a8correct SPKG.txt syntax

@dimpase
Copy link
Member Author

dimpase commented Jan 22, 2022

comment:22

OK, this builds (from a clean repo) and passes tests.

@mkoeppe mkoeppe modified the milestones: sage-9.6, sage-9.5 Jan 28, 2022
@vbraun
Copy link
Member

vbraun commented Jan 30, 2022

Changed branch from u/dimpase/packages/cryptominisat-better-fix to 76463a8

@vbraun vbraun closed this as completed in 4fc017f Jan 30, 2022
@rwst rwst mentioned this issue Jan 15, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: packages: optional p: blocker / 1 t: bug
Projects
None yet
Milestone
sage-9.5
Development

No branches or pull requests
3 participants
@vbraun @dimpase @mkoeppe