-
-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PARI-backed LaurentSeries truncates exact polynomials to default precision #33224
Labels
Milestone
Comments
This comment has been minimized.
This comment has been minimized.
Commit: |
Author: Lorenz Panny |
Branch: public/33224 |
yyyyx4
changed the title
loss of precision in EllipticCurve_field.weierstrass_p() with some algorithms
PARI-backed LaurentSeries truncates exact polynomials to default precision
Jan 24, 2022
Branch pushed to git repo; I updated commit sha1. New commits:
|
Reviewer: Frédéric Chapoton |
comment:6
ok, looks good enough |
Changed branch from public/33224 to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
On 9.5.rc3:
This happens because
construct_from_pari
inpower_series_pari.pyx
expands allt_RFRAC
elements to a power series using the parent ring's default precision (usually 20). However, this needlessly reduces the precision when thet_RFRAC
has denominator one, i.e., is actually a polynomial and can therefore be represented exactly as a power series. The fix is very simple: Check if the denominator equals1
.(This behaviour was identified as the root cause for the following loss of precision:)
Component: algebra
Author: Lorenz Panny
Branch/Commit:
9eb2145
Reviewer: Frédéric Chapoton
Issue created by migration from https://trac.sagemath.org/ticket/33224
The text was updated successfully, but these errors were encountered: