-
-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add github action running on each push #33263
Comments
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:3
Why not just |
comment:4
Which jobs does it cancel? |
comment:5
You may want to use #33233 |
comment:6
Replying to @mkoeppe:
Also perhaps the new built-in |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:9
Thanks for the feedback. I've now used |
comment:11
Replying to @mkoeppe:
But now it seems to rebuild all python packages instead of using them from the docker image as before. Is this a bug in prefix or did I use it wrong? |
This comment has been minimized.
This comment has been minimized.
comment:13
Sorry, it should be |
comment:14
Replying to @tobiasdiez:
The patchbot makes the same optimistic assumption, which is why it's broken so often... |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:16
Replying to @mkoeppe:
Thanks, that worked well! |
comment:17
Another idea, for a much faster build, would be to just work out of |
comment:18
I think with a bit more than 1.5h runtime, it is already reasonably fast. The actual build also only takes about 35mins, the rest is spent on the tests. Further optimization in my opinion will be a trade-off between time savings and reduced reliability, because you then have to think about invalidation of the cythonize cache etc. The point of this ticket is to pursue a different approach than the patchbot and really start from a clean state. I would propose to first gain experience with this, before we implement more fancy caching mechanisms (and in this case I would also prefer github actions builtin cache mechanism). |
comment:19
Sure, sounds good. |
comment:20
However I think it should only be run for branches on tickets set to |
comment:21
Hm... no, people set "needs_review" after a push, not before |
Dependencies: #33103 |
comment:22
OK, let's just merge it and try it out. I'd suggest to set #33103 as a dependency and already put |
Reviewer: Matthias Koeppe |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:25
Increasing priority as the badge is already added to the trac ticket (so that I don't have to login in the VM and change the config multiple times). |
Changed branch from public/build/github_build to |
Add a github action that runs on each push. Since it uses the most recent docker image as the base, the runtime is relatively short with about 2h. The idea is to get quick feedback on PRs without the need to wait until the patchbot picks it up. After this ticket is merged, we can add a badge in the ticket similar to the linter workflow.
Example run: https://github.com/sagemath/sagetrac-mirror/actions/workflows/build.yml
(it works but one doctest and the pytests are failing; I think there are already tickets for these issues)
Depends on #33103
CC: @mkoeppe @fchapoton
Component: build
Author: Tobias Diez
Branch/Commit:
6329816
Reviewer: Matthias Koeppe
Issue created by migration from https://trac.sagemath.org/ticket/33263
The text was updated successfully, but these errors were encountered: