Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GenericGraph.distance_matrix: accept keyword arguments for matrix constructor #33389

Closed
dcoudert opened this issue Feb 20, 2022 · 11 comments
Closed

Comments

@dcoudert
Copy link
Contributor

Following #33377, we allow method distance_matrix to pass arguments to the matrix constructors.

Depends on #33377

CC: @mkoeppe

Component: graph theory

Author: David Coudert

Branch/Commit: 8ca8b3b

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/33389

@dcoudert dcoudert added this to the sage-9.6 milestone Feb 20, 2022
@dcoudert
Copy link
Contributor Author

comment:1

I don't know if we can do better to separate keyword arguments.


Last 10 new commits:

fe1da0aMerge #32465
007253dsrc/sage/matrix/matrix_space.py (get_matrix_class): Handle base_ring=ZZ, implementation='numpy'
01d5541GenericGraph.adjacency_matrix: Accept keyword arguments for matrix constructor
03343f7GenericGraph.adjacency_matrix: Add doctest with immutable=True
688d054GenericGraph.weighted_adjacency_matrix: Accept keyword arguments for matrix constructor
e30c7cbGenericGraph.weighted_adjacency_matrix: Make base_ring a keyword-only argument
6f2185aGenericGraph.incidence_matrix: Accept keyword arguments for matrix constructor
0bd2930GenericGraph._matrix_: Use the new keyword argument base_ring of GenericGraph.adjacency_matrix
fbdcbf1trac #33389: merged with 9.6.beta2
83cbf50trac #33389: GenericGraph.distance_matrix: accept keyword arguments for matrix constructor

@dcoudert
Copy link
Contributor Author

Branch: public/graphs/33389_distance_matrix

@dcoudert
Copy link
Contributor Author

Commit: 83cbf50

@dcoudert
Copy link
Contributor Author

Dependencies: #33377

@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 20, 2022

comment:2

Typo: are not pass to -> are not passed to

Otherwise LGTM. Green bot => positive review

@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 20, 2022

Reviewer: Matthias Koeppe

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 20, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

8ca8b3btrac #33389: typo

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 20, 2022

Changed commit from 83cbf50 to 8ca8b3b

@dcoudert
Copy link
Contributor Author

comment:4

The patchbot is not green, but I think reported issues are not related to this ticket.

@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 21, 2022

comment:5

I agree

@vbraun
Copy link
Member

vbraun commented Feb 27, 2022

Changed branch from public/graphs/33389_distance_matrix to 8ca8b3b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants