Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sage.geometry.polyhedron: More # optional #33402

Closed
mkoeppe opened this issue Feb 23, 2022 · 15 comments
Closed

sage.geometry.polyhedron: More # optional #33402

mkoeppe opened this issue Feb 23, 2022 · 15 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 23, 2022

(cherry-picked from #32432)

CC: @kliem

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: 065c627

Reviewer: Jonathan Kliem

Issue created by migration from https://trac.sagemath.org/ticket/33402

@mkoeppe mkoeppe added this to the sage-9.6 milestone Feb 23, 2022
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 23, 2022

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 23, 2022

New commits:

460072dsrc/sage/geometry/polyhedron/base3.py: Mark a doctest # optional - sage.groups
57735d9src/sage/geometry/polyhedron/base3.py: Add some # optional - sage.rings.number_field, sage.combinat
f305cccsrc/sage/geometry/polyhedron/base3.py: Mark doctests # optional - sage.combinat
498a534src/sage/geometry/polyhedron/base3.py: Mark a doctest # optional - sage.number_field
a32bf42src/sage/geometry/polyhedron/library.py: Add # optional - sage.rings.number_field
07d7358src/sage/geometry/polyhedron/combinatorial_polyhedron/base.pyx: Add # optional - sage.combinat
8267aabsrc/sage/geometry/polyhedron/ppl_lattice_polytope.py b/src/sage/geometry/polyhedron/ppl_lattice_polytope.py: Mark doctests # optional - sage.groups sage.graphs
82f2e18src/sage/geometry/polyhedron/backend_normaliz.py: Add missing # optional - sage.rings.number_field

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 23, 2022

Commit: 82f2e18

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 23, 2022

Author: Matthias Koeppe

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 23, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

fa15fd3src/sage/geometry/polyhedron/base0.py: Add # optional - sage.rings.number_field

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 23, 2022

Changed commit from 82f2e18 to fa15fd3

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 23, 2022

Changed commit from fa15fd3 to 302bc3c

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 23, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

302bc3csrc/sage/geometry/polyhedron/face.py: Mark doctests # optional - sage.combinat

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 23, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

065c627src/sage/geometry/polyhedron/base1.py: Change an example from RR to RDF, add # optional - sage.rings.number_field, sage.symbolic

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 23, 2022

Changed commit from 302bc3c to 065c627

@mkoeppe

This comment has been minimized.

@kliem
Copy link
Contributor

kliem commented Feb 23, 2022

comment:7

LGTM.

@kliem
Copy link
Contributor

kliem commented Feb 23, 2022

Reviewer: Jonathan Kliem

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 23, 2022

comment:8

Thank you!

@vbraun
Copy link
Member

vbraun commented Mar 1, 2022

Changed branch from u/mkoeppe/sage_geometry_polyhedron__more___optional to 065c627

@vbraun vbraun closed this as completed in cc4ffb3 Mar 1, 2022
mkoeppe added a commit to mkoeppe/sage that referenced this issue Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants