Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH Actions: Fix homebrew-maximal, remove opensuse-15.2.1 #33430

Closed
mkoeppe opened this issue Feb 28, 2022 · 16 comments
Closed

GH Actions: Fix homebrew-maximal, remove opensuse-15.2.1 #33430

mkoeppe opened this issue Feb 28, 2022 · 16 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 28, 2022

homebrew-maximal is broken because there's no gcc@12 package yet.
https://github.com/sagemath/sage/runs/5353146513?check_suite_focus=true

opensuse-15.2.1 is broken badly because apparently the Docker image is not maintained (https://github.com/sagemath/sage/runs/5353145981?check_suite_focus=true), so this test is useless for us

The workflows for testing optional packages should not test sagemath_doc_pdf because that is best tested on top of the regular Sage build.

CC: @dimpase @kliem

Component: porting

Author: Matthias Koeppe

Branch/Commit: 1251c35

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/33430

@mkoeppe mkoeppe added this to the sage-9.6 milestone Feb 28, 2022
@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 1, 2022

Author: Matthias Koeppe

@mkoeppe mkoeppe changed the title GH Actions: Fix homebrew-maximal GH Actions: Fix homebrew-maximal, remove opensuse-15.2.1 Mar 1, 2022
@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 3, 2022

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 3, 2022

Commit: 1251c35

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 3, 2022

New commits:

06fe5d6build/pkgs/_gcc12/distros/homebrew.txt: Remove
30ec608.github/workflows, tox.ini: Remove opensuse-15.2.1 (defunct)
1251c35.github/workflows: Filter optional/experimental packages using --no-file huge --no-file has_nonfree_dependencies; filter out sagemath_doc_pdf

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 3, 2022

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 2, 2022

comment:7

Let's get this in please

@dimpase
Copy link
Member

dimpase commented Apr 3, 2022

comment:8

why does tox.ini still have opensuse-15.0,opensuse-15.1, opensuse-15.2, even though they are not used?

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 3, 2022

comment:9

tox.ini defines platforms that we can test.
Only a subset is run on GH Actions

@dimpase
Copy link
Member

dimpase commented Apr 4, 2022

comment:10

lgtm

@dimpase
Copy link
Member

dimpase commented Apr 4, 2022

Changed reviewer from https://github.com/mkoeppe/sage/actions/runs/1926493514 to Dima Pasechnik

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 4, 2022

comment:11

Thanks!

@vbraun
Copy link
Member

vbraun commented Apr 10, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants