Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move plotting and affine hull to Polyhedron_base6 #33449

Closed
kliem opened this issue Mar 2, 2022 · 11 comments
Closed

Move plotting and affine hull to Polyhedron_base6 #33449

kliem opened this issue Mar 2, 2022 · 11 comments
Labels
c: geometry p: major / 3 t: enhancement
Milestone
sage-9.6

Comments

@kliem
Copy link
Contributor

kliem commented Mar 2, 2022

Part of #32651.

We move plotting and affine hull methods to Polyhedron_base6.

CC: @mkoeppe

Component: geometry

Author: Jonathan Kliem

Branch: cf92e9f

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/33449
@kliem kliem added this to the sage-9.6 milestone Mar 2, 2022
@kliem
Copy link
Contributor Author

kliem commented Mar 2, 2022

Author: Jonathan Kliem

@mkoeppe
Copy link
Contributor

mkoeppe commented Mar 2, 2022

comment:2

The new file is not on the branch

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 2, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

cf92e9fadd new file

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 2, 2022

Changed commit from 5c726dc to cf92e9f

@kliem
Copy link
Contributor Author

kliem commented Mar 2, 2022

comment:4

Forgot that.

@mkoeppe
Copy link
Contributor

mkoeppe commented Mar 3, 2022

Reviewer: Matthias Koeppe

@mkoeppe
Copy link
Contributor

mkoeppe commented Mar 3, 2022

comment:6

The doctest failure is unrelated.

@kliem
Copy link
Contributor Author

kliem commented Mar 4, 2022

comment:7

Thank you.

@vbraun
Copy link
Member

vbraun commented Mar 8, 2022

Changed branch from u/gh-kliem/polyhedron_base6 to cf92e9f

@vbraun vbraun closed this as completed in a791c09 Mar 8, 2022
@slel
Copy link
Member

slel commented Mar 8, 2022

comment:9

Follow-up at #33480 regarding

  • a typo "was produce -> was produced"
  • a hardcoded version in a doctest

@slel
Copy link
Member

slel commented Mar 8, 2022

Changed commit from cf92e9f to none

@slel slel mentioned this issue Mar 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: geometry p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.6
Development

No branches or pull requests
4 participants
@vbraun @slel @mkoeppe @kliem