Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve vs code config #33450

Closed
tobiasdiez opened this issue Mar 2, 2022 · 5 comments
Closed

Improve vs code config #33450

tobiasdiez opened this issue Mar 2, 2022 · 5 comments
Labels
c: build p: critical / 2 t: enhancement
Milestone
sage-9.6

Comments

@tobiasdiez
Copy link
Contributor

Change the VS code config as follows:

  • Use the correct path to the python executable (python doesn't exists for me in bin, but python3 does)
  • Remove deprecated/unused config options
  • Exclude symlinks to sage/src from search, since otherwise they show up as multiple hits (please add such symlinks in the vs config in the future).

CC: @mkoeppe @fchapoton @jhpalmieri

Component: build

Author: Tobias Diez

Branch/Commit: 6f809f5

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/33450
@tobiasdiez tobiasdiez added this to the sage-9.6 milestone Mar 2, 2022
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 2, 2022

Changed commit from dfae4dc to 6f809f5

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 2, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

6f809f5src/doc/en/developer/packaging_sage_library.rst: Document that search.exclude needs to be updated

@mkoeppe
Copy link
Contributor

mkoeppe commented Mar 2, 2022

Reviewer: Matthias Koeppe

@tobiasdiez
Copy link
Contributor Author

comment:4

Thanks!

@vbraun
Copy link
Member

vbraun commented Mar 8, 2022

Changed branch from public/build/vscode_improve_config to 6f809f5

@vbraun vbraun closed this as completed in c5fb4c7 Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: build p: critical / 2 t: enhancement
Projects
None yet
Milestone
sage-9.6
Development

No branches or pull requests
3 participants
@vbraun @tobiasdiez @mkoeppe