Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package CyLP #33487

Closed
mkoeppe opened this issue Mar 9, 2022 · 15 comments
Closed

Package CyLP #33487

mkoeppe opened this issue Mar 9, 2022 · 15 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Mar 9, 2022

https://github.com/coin-or/CyLP

Needed for running cvxpy (#31962) with a CBC backend.

CC: @sheerluck @tkralphs @seblabbe @dcoudert @dimpase

Component: packages: optional

Author: Matthias Koeppe

Branch/Commit: 8b27e69

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/33487

@mkoeppe mkoeppe added this to the sage-9.7 milestone Mar 9, 2022
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 9, 2022

Branch: u/mkoeppe/package_cylp

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 9, 2022

comment:2

Is building with CYLP_USE_CYTHON=1 still supported / ever tested?
Fails for me without diagnostics

[cylp-0.91.4]   running build_ext
[cylp-0.91.4]   cythoning cylp/cy/CyClpPrimalColumnPivotBase.pyx to cylp/cy/CyClpPrimalColumnPivotBase.cpp
[cylp-0.91.4]   error: /Users/mkoeppe/s/sage/sage-rebasing/worktree-gcc11/local/var/lib/sage/venv-python3.10/var/tmp/sage/build/cylp-0.91.4/src/cylp/cy/CyClpPrimalColumnPivotBase.pyx
[cylp-0.91.4]   error: subprocess-exited-with-error

New commits:

3edafecbuild/pkgs/cylp: New

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 9, 2022

Commit: 3edafec

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 9, 2022

comment:3

Without CYLP_USE_CYTHON, running into coin-or/CyLP#148 with Python 3.10.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 9, 2022

Changed commit from 3edafec to 8b27e69

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 9, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

8b27e69build/pkgs/cylp: Add megapatch 'Re-generating with Cython 0.29.27 for Python 3.10 compatibility', do not use CYLP_USE_CYTHON

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 9, 2022

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 9, 2022

comment:5

This works for me on macOS with Python 3.10 and CBC 2.10.7 installed from homebrew. https://github.com/coin-or/CyLP#modeling-example works as expected.

@mkoeppe mkoeppe modified the milestones: sage-9.7, sage-9.6 Mar 9, 2022
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 9, 2022

comment:8

Also builds OK with tox -e docker-ubuntu-trusty-maximal -- cylp (this uses our cbc spkg, currently still at 2.9.4)

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 9, 2022

comment:9

Also builds OK with tox -e docker-ubuntu-bionic-maximal -- cylp (using system coinor-cbc (2.9.9+repack1-1))

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 9, 2022

comment:10

I'll not run the full portability suite now. I think this is good enough for a new optional package.

@tscrim
Copy link
Collaborator

tscrim commented Mar 10, 2022

comment:11

That is a pretty massive patch. Although I guess the time for them for the next release is probably a bit away, so I guess it is necessary.

This builds and works fine for me.

@tscrim
Copy link
Collaborator

tscrim commented Mar 10, 2022

Reviewer: Travis Scrimshaw

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 10, 2022

comment:13

Thanks!

@vbraun
Copy link
Member

vbraun commented Mar 20, 2022

Changed branch from u/mkoeppe/package_cylp to 8b27e69

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants