refresh the file subword.py

[fchapoton]

Various details:

• pep8 cleanup
• annotations
• add method __ne__
• tweaks in smallest_positions
• typos

CC: @tscrim @slel @kwankyu

Component: combinatorics

Author: Frédéric Chapoton

Branch/Commit: 5d5a72f

Reviewer: Travis Scrimshaw, Samuel Lelièvre

Issue created by migration from https://trac.sagemath.org/ticket/33555

[fchapoton]

Branch: u/chapoton/33555

[fchapoton]

Commit: e411b13

[fchapoton]

New commits:

e411b13

refresh the file combinat/subword.py

[fchapoton]

comment:3

green bot, so please review

[tscrim]

Reviewer: Travis Scrimshaw

[tscrim]

comment:4

One extra change would be __repr__() -> _repr_() (so rename() can work). If you don't want to do that, then you can set a positive review.

[sagetrac-git]

Changed commit from e411b13 to c966ef1

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

c966ef1

using `_repr_` in subword

[fchapoton]

comment:7

thanks, ok, here we go.

This file seems to be used nowhere inside sage..

[tscrim]

comment:8

Thanks.

Indeed, but it is globally imported in combinat.all. Perhaps we should also take this opportunity to make it a lazy_import?

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

4081734

lazify import of subword

[sagetrac-git]

Changed commit from c966ef1 to 4081734

[fchapoton]

comment:10

good idea. Voilà

[tscrim]

comment:11

Thanks. LGTM.

[slel]

comment:12

For multiline imports, how about

• parentheses instead of line continuation with backslash?
• sorting by alphabet or theme (unless the order reflects
  dependencies among imports)?

For instance:

-from .combinat import bell_number, catalan_number, euler_number, fibonacci, \
-    lucas_number1, lucas_number2, stirling_number1, stirling_number2, \
-    polygonal_number, CombinatorialObject, CombinatorialClass, \
-    MapCombinatorialClass, \
-    tuples, number_of_tuples, unordered_tuples, number_of_unordered_tuples, \
-    bell_polynomial, fibonacci_sequence, fibonacci_xrange, bernoulli_polynomial
+from .combinat import (
+    CombinatorialClass, CombinatorialObject, MapCombinatorialClass,
+    bell_number, bell_polynomial, bernoulli_polynomial,
+    catalan_number, euler_number,
+    fibonacci, fibonacci_sequence, fibonacci_xrange,
+    lucas_number1, lucas_number2, polygonal_number,
+    stirling_number1, stirling_number2,
+    tuples, number_of_tuples,
+    unordered_tuples, number_of_unordered_tuples
+)

Maybe reword "inheritate from when needed"
to "inherit from it when needed".

Maybe rephrase:

-As repetition can occur in the initial word, the subwords of a given word is
-not a set in general but an enumerated multiset!
+As repetition can occur in the initial word, in general subwords
+of a given word form an enumerated multiset rather than a set!

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

5d5a72f

reviewer's suggested details

[sagetrac-git]

Changed commit from 4081734 to 5d5a72f

[fchapoton]

comment:14

voilà, c'est fait

[slel]

Changed reviewer from Travis Scrimshaw to Travis Scrimshaw, Samuel Lelièvre

[slel]

comment:15

I think "inheritate" should be "inherit" if you can fix that too.

More long import lines could be wrapped but not necessarily here.

If bots green, good to go.

[fchapoton]

comment:16

setting to positive, thanks

[vbraun]

Changed branch from u/chapoton/33555 to 5d5a72f