Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CombinatorialPolyhedron: Cache is_simple, is_simplicial #33644

Closed
kliem opened this issue Apr 5, 2022 · 7 comments
Closed

CombinatorialPolyhedron: Cache is_simple, is_simplicial #33644

kliem opened this issue Apr 5, 2022 · 7 comments
Labels
c: geometry p: major / 3 t: enhancement
Milestone
sage-9.6

Comments

@kliem
Copy link
Contributor

kliem commented Apr 5, 2022

CC: @tscrim @yuan-zhou

Component: geometry

Author: Jonathan Kliem

Branch/Commit: d64cf60

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/33644
@kliem kliem added this to the sage-9.6 milestone Apr 5, 2022
@kliem
Copy link
Contributor Author

kliem commented Apr 5, 2022

Branch: public/33644

@kliem
Copy link
Contributor Author

kliem commented Apr 5, 2022

Commit: d64cf60

@kliem
Copy link
Contributor Author

kliem commented Apr 5, 2022

New commits:

d64cf60cache is_simple and is_simplicial for CombinatorialPolyhedron

@tscrim
Copy link
Collaborator

tscrim commented Apr 5, 2022

comment:2

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Apr 5, 2022

Reviewer: Travis Scrimshaw

@kliem
Copy link
Contributor Author

kliem commented Apr 5, 2022

comment:3

Thank you.

@vbraun
Copy link
Member

vbraun commented Apr 10, 2022

Changed branch from public/33644 to d64cf60

@vbraun vbraun closed this as completed in 34adbe3 Apr 10, 2022
@kliem kliem mentioned this issue May 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: geometry p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.6
Development

No branches or pull requests
3 participants
@vbraun @tscrim @kliem