Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pep cleanup for tableau_tuple #33669

Closed
fchapoton opened this issue Apr 10, 2022 · 8 comments
Closed

pep cleanup for tableau_tuple #33669

fchapoton opened this issue Apr 10, 2022 · 8 comments
Labels
c: combinatorics p: minor / 4 t: enhancement
Milestone
sage-9.7

Comments

@fchapoton
Copy link
Contributor

also fixing some lgtm suggestions about unreachable code and unused variables

CC: @tscrim @slel @kliem @kwankyu

Component: combinatorics

Author: Frédéric Chapoton

Branch/Commit: 1cbfad5

Reviewer: Jonathan Kliem

Issue created by migration from https://trac.sagemath.org/ticket/33669
@fchapoton fchapoton added this to the sage-9.6 milestone Apr 10, 2022
@fchapoton
Copy link
Contributor Author

Commit: 1cbfad5

@fchapoton
Copy link
Contributor Author

New commits:

1cbfad5cleaning tableau_tuple (pep8, unused code)

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/33669

@fchapoton
Copy link
Contributor Author

comment:2

green bot, so please review. Maybe a little boring, sorry.

@kliem
Copy link
Contributor

kliem commented Apr 11, 2022

comment:3

LGTM.

@kliem
Copy link
Contributor

kliem commented Apr 11, 2022

Reviewer: Jonathan Kliem

@fchapoton
Copy link
Contributor Author

comment:5

bump to 9.7

@fchapoton fchapoton modified the milestones: sage-9.6, sage-9.7 Apr 22, 2022
@vbraun
Copy link
Member

vbraun commented May 24, 2022

Changed branch from u/chapoton/33669 to 1cbfad5

@vbraun vbraun closed this as completed in cf7d877 May 24, 2022
This was referenced May 22, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: combinatorics p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-9.7
Development

No branches or pull requests
4 participants
@vbraun @fchapoton @mkoeppe @kliem