-
-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make representation integers exportable and small improvements to backend ppl #33678
Milestone
Comments
Branch: public/33678 |
Commit: |
Reviewer: Travis Scrimshaw |
comment:3
Personally, I am not a fan of the |
comment:4
Thank you. |
Changed branch from public/33678 to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In
backend_ppl.py
we currently manually copy the integers representing the different representation types inrepresentation.py
. In this ticket we change this to an import. This is easier to read and less error prone.In addition we outsource to abstract methods to create a ppl generator resp. constraint system.
CC: @tscrim @yuan-zhou @mkoeppe
Component: geometry
Author: Jonathan Kliem
Branch/Commit:
94bd1ee
Reviewer: Travis Scrimshaw
Issue created by migration from https://trac.sagemath.org/ticket/33678
The text was updated successfully, but these errors were encountered: