Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update src/doc/en/developer/coding_basics.rst and coding_in_python.rst regarding imports #33754

Closed
mkoeppe opened this issue Apr 25, 2022 · 13 comments
Closed

Update src/doc/en/developer/coding_basics.rst and coding_in_python.rst regarding imports #33754

mkoeppe opened this issue Apr 25, 2022 · 13 comments
Labels
c: documentation p: major / 3 t: bug
Milestone
sage-9.7

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Apr 25, 2022

It gives some outdated advice regarding "all.py"

it should point to https://doc.sagemath.org/html/en/developer/packaging_sage_library.html#dependencies-and-distribution-packages

Also we add some material from https://wiki.sagemath.org/import (and delete it there, and also delete outdated material there).

CC: @kwankyu @yuan-zhou @tscrim @fchapoton @jhpalmieri

Component: documentation

Author: Matthias Koeppe

Branch/Commit: c554704

Reviewer: John Palmieri

Issue created by migration from https://trac.sagemath.org/ticket/33754
@mkoeppe mkoeppe added this to the sage-9.6 milestone Apr 25, 2022
@mkoeppe
Copy link
Member Author

mkoeppe commented Apr 25, 2022

Author: Matthias Koeppe

@mkoeppe mkoeppe changed the title Update src/doc/en/developer/coding_basics.html regarding imports Update src/doc/en/developer/coding_basics.rst regarding imports Apr 25, 2022
@mkoeppe
Copy link
Member Author

mkoeppe commented Apr 25, 2022

Branch: u/mkoeppe/update_src_doc_en_developer_coding_basics_html_regarding_imports

@mkoeppe
Copy link
Member Author

mkoeppe commented Apr 25, 2022

Commit: 0e4e618

@mkoeppe
Copy link
Member Author

mkoeppe commented Apr 25, 2022

New commits:

0e4e618src/doc/en/developer/coding_basics.rst: Update advice regarding packages

@mkoeppe mkoeppe changed the title Update src/doc/en/developer/coding_basics.rst regarding imports Update src/doc/en/developer/coding_basics.rst and coding_in_python.rst regarding imports Apr 25, 2022
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 25, 2022

Changed commit from 0e4e618 to 26650f9

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 25, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

ca98d8asrc/doc/en/developer/coding_basics.rst: Link to Python tutorial for 'package'
9340940src/doc/en/developer/coding_in_python.rst: Link to section in packaging_sage_library.rst
26650f9src/doc/en/developer/coding_in_python.rst: Add lazy_import advice from https://wiki.sagemath.org/import

@mkoeppe

This comment has been minimized.

Sign in to view
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 25, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

c554704src/doc/en/developer/coding_in_python.rst: Fix up for cachefunc

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 25, 2022

Changed commit from 26650f9 to c554704

@mkoeppe mkoeppe modified the milestones: sage-9.6, sage-9.7 Apr 25, 2022
@jhpalmieri
Copy link
Member

Reviewer: John Palmieri

@jhpalmieri
Copy link
Member

comment:10

Looks good to me.

@mkoeppe
Copy link
Member Author

mkoeppe commented Jul 16, 2022

comment:11

Thanks!

@vbraun
Copy link
Member

vbraun commented Jul 21, 2022

Changed branch from u/mkoeppe/update_src_doc_en_developer_coding_basics_html_regarding_imports to c554704

@vbraun vbraun closed this as completed in abbc7c5 Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: documentation p: major / 3 t: bug
Projects
None yet
Milestone
sage-9.7
Development

No branches or pull requests
3 participants
@vbraun @jhpalmieri @mkoeppe