sage-dist-helpers (sdh_pip_install): Change default to --build-isolation

[mkoeppe]

... hence, provisioning the build environment for each package from the stored wheels.

This gets us another step closer to using modern Python packaging infrastructure. It will make the build process more robust because it avoids concurrent read and write access to site-packages.

If it fails, it falls back the old behavior (--no-build-isolation) and issues a warning.

CC: @jhpalmieri

Component: build

Author: Matthias Koeppe

Branch/Commit: 378d704

Reviewer: John Palmieri

Issue created by migration from https://trac.sagemath.org/ticket/33789

[mkoeppe]

Branch: u/mkoeppe/sage_dist_helpers__sdh_pip_install___change_default_to___build_isolation

[sagetrac-git]

Commit: f6ba526

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

738ab26	build/bin/sage-dist-helpers (sdh_pip_install): Change default to --build-isolation
79c6002	build/bin/sage-dist-helpers (sdh_pip_install): Fall back to --no-build-isolation on error
f6ba526	build/pkgs/tomli/spkg-install.in: Build it with --no-build-isolation

[mkoeppe]

Author: Matthias Koeppe

[jhpalmieri]

comment:5

Why does tomli require no-build-isolation? Also, a comment like "Our new default" is going to become dated. Maybe "The default as of Sage 9.7" instead?

[sagetrac-git]

Changed commit from f6ba526 to caaef55

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

caaef55

build/pkgs/tomli/spkg-install.in: Expand comments on build dependencies / isolation

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

378d704

build/bin/sage-dist-helpers: In a comment, be more specific about what 'new' is

[sagetrac-git]

Changed commit from caaef55 to 378d704

[jhpalmieri]

Reviewer: John Palmieri

[jhpalmieri]

comment:8

To clarify, build with isolation is the default in pip, right? So it makes sense for us to switch to this, except in cases where necessary. If that's correct, feel free to set to "positive review" on my behalf.

(Sage builds, including lots of optional packages, with this branch.)

[mkoeppe]

comment:9

Yes, it's the default in pip.

[mkoeppe]

comment:10

Thanks!

[vbraun]

Changed branch from u/mkoeppe/sage_dist_helpers__sdh_pip_install___change_default_to___build_isolation to 378d704