Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some pathlib in combinat and groups #33809

Closed
fchapoton opened this issue May 5, 2022 · 10 comments
Closed

some pathlib in combinat and groups #33809

fchapoton opened this issue May 5, 2022 · 10 comments
Labels
c: combinatorics p: major / 3 t: enhancement
Milestone
sage-9.7

Comments

@fchapoton
Copy link
Contributor

and other details

CC: @tscrim

Component: combinatorics

Author: Frédéric Chapoton

Branch: 8a4ae36

Reviewer: David Coudert

Issue created by migration from https://trac.sagemath.org/ticket/33809
@fchapoton fchapoton added this to the sage-9.7 milestone May 5, 2022
@fchapoton
Copy link
Contributor Author

Commit: 8a4ae36

@fchapoton
Copy link
Contributor Author

New commits:

8a4ae36some use of pathlib.Path in combinat and groups

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/33809

@dcoudert
Copy link
Contributor

comment:2

LGTM.

I didn't know the Path class and so the notation file = path / 'cluster_algebra_quiver' / f'mutation_classes_{n}.dig6'.

@dcoudert
Copy link
Contributor

Reviewer: David Coudert

@fchapoton
Copy link
Contributor Author

comment:3

merci

oui, c'est pratique. Si je comprends bien, sympy utilise ca partout maintenant.

@vbraun
Copy link
Member

vbraun commented May 22, 2022

Changed branch from u/chapoton/33809 to 8a4ae36

@vbraun vbraun closed this as completed in af23627 May 22, 2022
@mkoeppe
Copy link
Contributor

mkoeppe commented Jul 3, 2022

Changed commit from 8a4ae36 to none

@mkoeppe
Copy link
Contributor

mkoeppe commented Jul 3, 2022

comment:5

I think this ticket caused the reported failures AttributeError: 'PosixPath' object has no attribute '_libgap_init_' when gap_packages is installed. https://groups.google.com/g/sage-release/c/JZ5WOz2BNvA/m/GgIt-_3vAwAJ

@mkoeppe
Copy link
Contributor

mkoeppe commented Jul 4, 2022

comment:6

opened #34111 for a fix

This was referenced May 22, 2022
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: combinatorics p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.7
Development

No branches or pull requests
4 participants
@vbraun @fchapoton @mkoeppe @dcoudert