-
-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor distributions sagemath-{objects,categories} through sagemath-{environment,repl} #33812
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Commit: |
comment:5
Now that we are testing sagemath-objects with the stuff now in sagemath-environment stripped away, dependencies become apparent that need to be removed.
|
Author: Matthias Koeppe |
This comment has been minimized.
This comment has been minimized.
comment:7
So this needs #33037 (Remove use of |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Work Issues: Overriding SAGE_EDITABLE does not work |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Changed dependencies from #33817 to none |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:60
Questions:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:62
Replying to Kwankyu Lee:
Sorry.. The hierarchy diagram is the hierarchy of the distribution pkgs. I now see the correct dependencies in New commits:
|
comment:63
The distribution packages declare runtime dependencies (setup.cfg install_requires) and also build-time dependencies (pyproject.toml). I think in the diagram I only show the (covers of) runtime dependencies. |
comment:64
Then perhaps the change of the commit |
comment:65
No, you spotted it correctly in comment:62. |
Changed reviewer from https://github.com/mkoeppe/sage/runs/7511007092 to Kwankyu Lee |
New commits:
|
comment:68
What is the logic of the changes in |
comment:69
Replying to Kwankyu Lee:
It seems a provision to avoid How about adding a comment to the code to explain the situation more concretely? |
comment:71
Thanks for the comment.
+++ b/build/pkgs/sagemath_repl/install-requires.txt
@@ -0,0 +1,2 @@
+# This file is updated on every release by the sage-update-version script
+sagemath-repl ~= 9.7b6 I tested this ticket in several ways. It works well. It looks good to me. New commits:
|
comment:72
Thank you! |
Currently sagemath-categories distributes a superset of sagemath-objects, and both distributions include a copy of the doctester for their doctesting. We remove this duplication by declaring install-requires and extras-require.
The dependencies are illustrated in the updated developer's guide - https://e019add9a8540b8213dfc563e8e4bda04777282c--sagemath-tobias.netlify.app/developer/packaging_sage_library.html#hierarchy-of-distribution-packages
As #33817 is a dependency, this ticket can be tested by running
This test is also run as part of the "Build&Test" workflow.
CC: @kwankyu
Component: refactoring
Author: Matthias Koeppe
Branch/Commit:
e5d1070
Reviewer: Kwankyu Lee
Issue created by migration from https://trac.sagemath.org/ticket/33812
The text was updated successfully, but these errors were encountered: