Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tweak our .lgtm file, add documentation #33867

Closed
fchapoton opened this issue May 18, 2022 · 12 comments
Closed

tweak our .lgtm file, add documentation #33867

fchapoton opened this issue May 18, 2022 · 12 comments
Labels
p: major / 3 t: enhancement t: refactoring
Milestone
sage-9.7

Comments

@fchapoton
Copy link
Contributor

by not checking the all_*.py files

CC: @mkoeppe

Component: refactoring

Author: Frédéric Chapoton

Branch/Commit: 2457c05

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/33867
@fchapoton fchapoton added this to the sage-9.7 milestone May 18, 2022
@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/33867

@fchapoton
Copy link
Contributor Author

New commits:

6a78489tweak our .lgtm file

@fchapoton
Copy link
Contributor Author

Commit: 6a78489

@mkoeppe
Copy link
Contributor

mkoeppe commented May 18, 2022

comment:2

Could you add a little bit of documentation about this in src/doc/en/developer/tools.rst? Developer tools are more effective if developers know about them

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 18, 2022

Changed commit from 6a78489 to de00a57

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 18, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

de00a57some words about lgtm

@fchapoton
Copy link
Contributor Author

comment:4

voilà

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 19, 2022

Changed commit from de00a57 to 2457c05

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 19, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

2457c05better rst

@mkoeppe
Copy link
Contributor

mkoeppe commented May 19, 2022

comment:6

lgtm lgtm.

@mkoeppe
Copy link
Contributor

mkoeppe commented May 19, 2022

Reviewer: Matthias Koeppe

@mkoeppe mkoeppe changed the title tweak our .lgtm file tweak our .lgtm file, add documentation May 19, 2022
@vbraun
Copy link
Member

vbraun commented May 24, 2022

Changed branch from u/chapoton/33867 to 2457c05

@vbraun vbraun closed this as completed in 0039cce May 24, 2022
This was referenced May 22, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-9.7
Development

No branches or pull requests
3 participants
@vbraun @fchapoton @mkoeppe